Better struct assert (#97)

Signed-off-by: Oleg Kovalov <oleg@hey.com>
cristalhq · Jul 17, 2021 · 5ae6b2e · 5ae6b2e
1 parent 0d4c5d9
commit 5ae6b2e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/aconfig_test.go b/aconfig_test.go
@@ -1061,7 +1061,7 @@ func TestDontFillFlagsIfDisabled(t *testing.T) {
 	}
 }
 
-func TestPassNonStructs(t *testing.T) {
+func TestPassBadStructs(t *testing.T) {
 	f := func(cfg interface{}) {
 		t.Helper()
 
@@ -1080,6 +1080,11 @@ func TestPassNonStructs(t *testing.T) {
 	f([]string{})
 	f([4]string{})
 	f(func() {})
+
+	type S struct {
+		Foo int
+	}
+	f(S{})
 }
 
 func TestBadRequiredTag(t *testing.T) {

diff --git a/utils.go b/utils.go
@@ -15,6 +15,9 @@ func assertStruct(x interface{}) {
 		panic("aconfig: nil should not be passed to the Loader")
 	}
 	value := reflect.ValueOf(x)
+	if value.Type().Kind() != reflect.Ptr {
+		panic("aconfig: destination must be a pointer")
+	}
 	for value.Type().Kind() == reflect.Ptr {
 		value = value.Elem()
 	}