Skip to content

Commit

Permalink
Fix map of slices (#102)
Browse files Browse the repository at this point in the history
Signed-off-by: Oleg Kovalov <oleg@hey.com>
  • Loading branch information
cristaloleg committed Aug 15, 2021
1 parent 32ffc95 commit 4599e98
Show file tree
Hide file tree
Showing 2 changed files with 30 additions and 0 deletions.
29 changes: 29 additions & 0 deletions aconfig_test.go
Expand Up @@ -2,6 +2,7 @@ package aconfig

import (
"io/ioutil"
"net/url"
"os"
"reflect"
"strings"
Expand Down Expand Up @@ -1389,3 +1390,31 @@ func TestMapOfMap(t *testing.T) {
t.Fatalf("want %v, got %v", want, got)
}
}

func TestBad(t *testing.T) {
type TestConfig struct {
Params url.Values
}
var cfg TestConfig
os.Setenv("PARAMS", "foo:bar")
defer os.Unsetenv("PARAMS")

loader := LoaderFor(&cfg, Config{
SkipFlags: true,
})
if err := loader.Load(); err != nil {
t.Fatal(err)
}

p, err := url.ParseQuery("foo=bar")
if err != nil {
t.Fatal(err)
}
var want = TestConfig{
Params: p,
}

if got := cfg; !reflect.DeepEqual(want, got) {
t.Fatalf("want %v, got %v", want, got)
}
}
1 change: 1 addition & 0 deletions reflection.go
Expand Up @@ -320,6 +320,7 @@ func (l *Loader) setMap(field *fieldData, value string) error {
}

fdv := l.newSimpleFieldData(reflect.New(field.field.Type.Elem()).Elem())
fdv.field.Type = field.field.Type.Elem()
if err := l.setFieldData(fdv, val); err != nil {
return fmt.Errorf("incorrect map value %q: %w", val, err)
}
Expand Down

0 comments on commit 4599e98

Please sign in to comment.