Skip to content

Commit

Permalink
refactor(core): remove custom globalThis (angular#40123)
Browse files Browse the repository at this point in the history
This is provided by TypeScript since version 3.4

PR Close angular#40123
  • Loading branch information
alan-agius4 authored and josephperrott committed Dec 17, 2020
1 parent effc079 commit 475468c
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 5 deletions.
2 changes: 0 additions & 2 deletions packages/core/src/util/global.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@ declare var WorkerGlobalScope: any /** TODO #9100 */;
// We don't want to include the whole node.d.ts this this compilation unit so we'll just fake
// the global "global" var for now.
declare var global: any /** TODO #9100 */;
// Not yet available in TypeScript: https://github.com/Microsoft/TypeScript/pull/29332
declare var globalThis: any /** TODO #9100 */;

const __globalThis = typeof globalThis !== 'undefined' && globalThis;
const __window = typeof window !== 'undefined' && window;
Expand Down
3 changes: 0 additions & 3 deletions packages/core/test/util/global_spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@

import {global} from '../../src/util/global';

// Not yet available in TypeScript: https://github.com/Microsoft/TypeScript/pull/29332
declare var globalThis: any /** TODO #9100 */;

{
describe('global', () => {
it('should be global this value', () => {
Expand Down

0 comments on commit 475468c

Please sign in to comment.