Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contrib/test/int/build: bump a few deps #4383

Closed
wants to merge 1 commit into from
Closed

contrib/test/int/build: bump a few deps #4383

wants to merge 1 commit into from

Conversation

kolyshkin
Copy link
Collaborator

What type of PR is this?

/kind ci

What this PR does / why we need it:

contrib/test/int/build: bump a few deps

Notably:

conmon:      v2.0.15 -> v2.0.20
bats:        v1.2.0  -> v1.2.1
cni-plugins: v0.8.4  -> v0.8.7

Those were already bumped for circleci multiple times
(see commits 65fe2c5, d9ea392, 40b9d97, e48d23a)
but not here.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@kolyshkin
contrib/test/int/build: bump a few deps
c46a900 
conmon:	v2.0.15 -> v2.0.20
bats:	v1.2.0 -> v1.2.1
cni-plugins: v0.8.4 -> v0.8.7

Those were already bumped for circleci multiple times
(see commits 65fe2c5, d9ea392, 65fe2c5, 40b9d97, e48d23a)
but not here.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@openshift-ci-robot openshift-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/ci Categorizes issue or PR as related to CI dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Nov 19, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kolyshkin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2020
@codecov
Copy link

codecov bot commented Nov 19, 2020

Codecov Report

Merging #4383 (c46a900) into master (0fcc2a5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4383   +/-   ##
=======================================
  Coverage   39.29%   39.29%           
=======================================
  Files         112      112           
  Lines        8835     8835           
=======================================
  Hits         3472     3472           
  Misses       4977     4977           
  Partials      386      386

@kolyshkin
Copy link
Collaborator Author

e2e_features_rhel failure is a flake that should be fixed by #4350 (last commit)

/test e2e_features_rhel

@TomSweeneyRedHat
Copy link
Contributor

LGTM
assuming happy tests

@haircommander
Copy link
Member

can you revert the conmon fix to see if it is the one that broke
Kubernetes e2e suite: [k8s.io] [sig-node] Pods Extended [k8s.io] Pod Container Status should never report success for a pending container

@kolyshkin
Copy link
Collaborator Author

Same single failure in e2e_crun and e2e_rhel:

Kubernetes e2e suite: [k8s.io] [sig-node] Pods Extended [k8s.io] Pod Container Status should never report success for a pending container
/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/test/e2e/node/pods.go:206
Nov 19 04:53:04.235: timed out waiting for watch events for pod-submit-status-0-8
/usr/local/go/src/runtime/asm_amd64.s:1374

/retest

@haircommander
Copy link
Member

seems like it's not just this one #4370 (comment)

This was referenced Nov 19, 2020
Closed
Closed
@kolyshkin
Copy link
Collaborator Author

seems like it's not just this one #4370 (comment)

opened #4385

@kolyshkin
Copy link
Collaborator Author

/test e2e-agnostic

mrunalp
mrunalp reviewed Nov 20, 2020
View reviewed changes
contrib/test/integration/build/conmon.yml
@@ -4,7 +4,7 @@
git:
repo: "https://github.com/containers/conmon.git"
dest: "{{ ansible_env.GOPATH }}/src/github.com/containers/conmon"
version: v2.0.15
version: v2.0.20
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a quay image update as well.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do once we merge #4351. Or should I combine both PRs into one?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, let me merge this one into #4351

@kolyshkin
Copy link
Collaborator Author

/test e2e-agnostic

1 similar comment
@kolyshkin
Copy link
Collaborator Author

/test e2e-agnostic

@openshift-merge-robot
Copy link
Contributor

@kolyshkin: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-agnostic c46a900 link /test e2e-agnostic

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kolyshkin
Copy link
Collaborator Author

OK, let me merge this one into #4351

@kolyshkin kolyshkin closed this Nov 25, 2020
@kolyshkin kolyshkin mentioned this pull request Nov 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp mrunalp left review comments

@runcom runcom Awaiting requested review from runcom

@fidencio fidencio Awaiting requested review from fidencio

@nalind nalind Awaiting requested review from nalind

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/ci Categorizes issue or PR as related to CI release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@kolyshkin @openshift-ci-robot @TomSweeneyRedHat @haircommander @openshift-merge-robot @mrunalp