Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable/disable some e2e tests; rm TODOs; rework regex #4350

Merged
merged 4 commits into from
Nov 19, 2020

Commits on Nov 18, 2020

  1. contrib/test/int/e2e: rm obsoleted TODO

    Commit 7d2bde1 (Dec 8 2017) adds the TODO item, and excludes
    the "should.support.inline.execution.and.attach" test case.
    
    Now, commit 54d1971 (Jun 24 2019) removes this test from the
    exclude regexp, but forgots to remove the TODO.
    
    Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    kolyshkin committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    5e57f42 View commit details
    Browse the repository at this point in the history
  2. contrib/test/int/e2e: rework "skip" regex

    In its current form, it is very hard to read, maintain, or make any
    sense out of.
    
    Play with ansible/jinja a bit to enable much simpler way to list
    the tests to skip.
    
    The downside is we have to play some tricks to create a regular
    expression:
    
     1. join the elements of skip_tests via |
     2. replace spaces with \\s
     3. prepend square brackets and parentheses with \\
    
    Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    kolyshkin committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    fd15db0 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2020

  1. contrib/test/int/e2e-features: rework "skip" regex

    See the previous commit for details.
    
    Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    kolyshkin committed Nov 19, 2020
    Configuration menu
    Copy the full SHA
    f1b6fde View commit details
    Browse the repository at this point in the history
  2. contrib/test/int/e2e-features: skip Serial tests

    This is mostly done to fix the flake caused by the test case
    
    > Kubernetes e2e suite: [sig-network] IngressClass [Feature:Ingress] should not set default value if no default IngressClass [Serial]
    
    which fails like this:
    
    > ingressclasses.networking.k8s.io "ingressclass1" already exists
    
    This test depends on a system state and thus can't be run in parallel.
    It was marked as [Serial] recently (see [1]) but I just found out
    we do not skip Serial tests in e2e-features.
    
    Fix this.
    
    [1] kubernetes/kubernetes#93427
    
    Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    kolyshkin committed Nov 19, 2020
    Configuration menu
    Copy the full SHA
    22ce1d7 View commit details
    Browse the repository at this point in the history