add more explicit install instructions #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
might as well as libscrypt-devel as well.... although I can't get that to build. |
cretz
reviewed
Jul 31, 2023
| @@ -15,6 +15,28 @@ Features: | |||
| See info below, the [API docs](http://godoc.org/github.com/cretz/bine), and the [examples](examples). The project is | |||
| MIT licensed. The Tor docs/specs and https://github.com/yawning/bulb were great helps when building this. | |||
|
|
|||
| ## Installing | |||
| Bine requires tor-static, which cannot be installed by go's package manager. | |||
There was a problem hiding this comment.
Bine does not require tor-static. That's only if you want to link it statically (i.e. you opt in by importing github.com/cretz/bine/process/embedded). This is mentioned under "Example".
There was a problem hiding this comment.
I can't get it to work without tor-static existing, so I guess the example doesn't work.
There was a problem hiding this comment.
Please be more specific about the error you are encountering when running the example. Are you sure you are following all the steps such as "assuming tor is on the PATH"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not sure if this is even working correctly.
I'm still getting errors when trying to build a package.