Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.0.0-beta candidate - etsy v3 api + oAuth helper #40

Merged
merged 6 commits into from
Apr 3, 2022
Merged

1.0.0-beta candidate - etsy v3 api + oAuth helper #40

merged 6 commits into from
Apr 3, 2022

Conversation

creharmony
Copy link
Owner

Fix #39 Update Etsy API to v3 - special thanks to icemansparks 馃檹

Fix #36 v2 findAllShopSections : listingId argument not used

All reviewers are welcome : without feedbacks, this PR may be merged 3 april but next version will be beta and incomming changes / issues / PR are always welcome !

  • the typescript part still suffers from a lack of testing - @geopic

all feedback (positive/negative) are welcome

@boly38
Fix #39 Update Etsy API to v3
846cee0 
add very first manual oauth2 test
add manual steps + util function to get oauth2 access token
fix ci
@boly38
Fix #36 v2 findAllShopSections : listingId argument not used
8dc2af9
creharmony
creharmony commented Apr 2, 2022
View reviewed changes
Copy link
Owner Author

@creharmony creharmony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review to continue

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/EtsyClientV3.d.ts Outdated Show resolved Hide resolved
src/EtsyClientV3.js Outdated Show resolved Hide resolved
src/EtsyClientV3.js Show resolved Hide resolved
creharmony
creharmony commented Apr 2, 2022
View reviewed changes
package.json Outdated Show resolved Hide resolved
src/EtsyClientV2.js Outdated Show resolved Hide resolved
@creharmony creharmony added enhancement New feature or request MOC Maintenance in Operation Condition labels Apr 2, 2022
@creharmony creharmony self-assigned this Apr 2, 2022
@creharmony creharmony added this to the v1 milestone Apr 2, 2022
@boly38
Copy link
Collaborator

boly38 commented Apr 2, 2022 •
edited

it would be great to fix nyc too - nyc doc : adding .nycrc file

Todo

  • nyc is not working on this es6 project, even with Istanbul babel plugin doc => switch to c8

@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2022

Total Coverage: 92.53%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
src
聽 聽EtsyClientV2.js87.67%100%93.33%13, 153, 180, 181, 183, 188, 189, 195, 196, 197, 198, 199, 200, 210, 211, 212, 215, 216, 217, 218, 219, 220, 221, 27
聽 聽EtsyClientV3.js83.13%93.33%90.30%110, 111, 112, 113, 117, 118, 119, 120, 121, 13, 164, 168, 187, 213, 214, 215, 222, 223, 224, 226, 23, 231, 232, 238, 239, 240, 241, 242, 243, 253, 254, 255, 258, 259, 260, 261, 262, 263, 264, 28
聽 聽OAuth2Service.js72.73%100%94.89%103, 104, 105, 106, 107, 108, 116, 138, 139, 140, 141, 142, 150, 43, 47

@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2022

Total Coverage: 92.53%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
src
聽 聽EtsyClientV2.js87.67%100%93.33%13, 153, 180, 181, 183, 188, 189, 195, 196, 197, 198, 199, 200, 210, 211, 212, 215, 216, 217, 218, 219, 220, 221, 27
聽 聽EtsyClientV3.js83.13%93.33%90.30%110, 111, 112, 113, 117, 118, 119, 120, 121, 13, 164, 168, 187, 213, 214, 215, 222, 223, 224, 226, 23, 231, 232, 238, 239, 240, 241, 242, 243, 253, 254, 255, 258, 259, 260, 261, 262, 263, 264, 28
聽 聽OAuth2Service.js72.73%100%94.89%103, 104, 105, 106, 107, 108, 116, 138, 139, 140, 141, 142, 150, 43, 47

@boly38 boly38 merged commit b6945f9 into main Apr 3, 2022
@boly38 boly38 deleted the 39 branch April 3, 2022 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@creharmony creharmony

Labels
enhancement New feature or request MOC Maintenance in Operation Condition
Projects
None yet
Milestone
v1
Development

Successfully merging this pull request may close these issues.

Improvement: Update Etsy API to v3 findAllShopSections : listingId argument not used
2 participants
@creharmony @boly38