fix: 🐛 EPIPE message on exit again

src/creevey.ts

@@ -13,7 +13,6 @@ process.on('unhandledRejection', (reason) => {
   if (cluster.isWorker) return emitMessage<WorkerMessage>({ type: 'error', payload: { status: 'failed', error } });
   if (cluster.isMaster) {
     shutdownWorkers();
-    emitMessage<'shutdown'>('shutdown');
   }
 });
 

src/server/master/index.ts

@@ -5,7 +5,7 @@ import master from './master';
 import creeveyServer from './server';
 import creeveyApi from './api';
 import { Config, Options, isDefined } from '../../types';
-import { shutdownWorkers, emitMessage } from '../../utils';
+import { shutdownWorkers } from '../../utils';
 
 const copyFileAsync = promisify(copyFile);
 const readdirAsync = promisify(readdir);
@@ -55,7 +55,6 @@ export default async function (config: Config, options: Options): Promise<void>
       // TODO output summary
       process.exitCode = isSuccess ? 0 : -1;
       shutdownWorkers();
-      emitMessage<'shutdown'>('shutdown');
     });
     // TODO grep
     runner.start(Object.keys(runner.status.tests));

src/server/master/master.ts

@@ -3,7 +3,7 @@ import { Config, Test, isDefined, ServerTest } from '../../types';
 import { loadTestsFromStories } from '../../stories';
 import Runner from './runner';
 import { startWebpackCompiler } from './stories';
-import { shutdownWorkers, emitMessage } from '../../utils';
+import { shutdownWorkers } from '../../utils';
 
 function mergeTests(
   testsWithReports: Partial<{ [id: string]: Test }>,
@@ -50,12 +50,10 @@ export default async function master(config: Config): Promise<Runner> {
         new Promise((resolve) => runner.once('stop', resolve)),
       ]).then(() => {
         shutdownWorkers();
-        emitMessage<'shutdown'>('shutdown');
       });
       runner.stop();
     } else {
       shutdownWorkers();
-      emitMessage<'shutdown'>('shutdown');
     }
   });
 

src/server/master/pool.ts

@@ -144,8 +144,8 @@ export default class Pool extends EventEmitter {
 
   private gracefullyKill(worker: Worker): void {
     const timeout = setTimeout(() => worker.kill(), 10000);
+    worker.on('disconnect', () => clearTimeout(timeout));
     worker.send('shutdown');
     worker.disconnect();
-    worker.on('disconnect', () => clearTimeout(timeout));
   }
 }

src/server/master/webpack.ts

@@ -141,8 +141,6 @@ export default async function compile(config: Config, { debug }: Options): Promi
   const watcher = storybookWebpackCompiler.watch({}, handleWebpackBuild);
 
   subscribeOn('shutdown', () => {
-    console.log('[CreeveyWebpack]: Stop watching and shuting down');
     watcher.close(noop);
-    process.on('exit', () => console.log('[CreeveyWebpack]: process exiting'));
   });
 }

src/server/worker/selenium.ts

@@ -280,8 +280,7 @@ export async function getBrowser(config: Config, browserConfig: BrowserConfig):
   const browser = await new Builder().usingServer(gridUrl).withCapabilities(capabilities).build();
 
   subscribeOn('shutdown', () => {
-    console.log('[CreeveyWorker]:', `Closing browser session ${process.pid}`);
-    browser.quit().then(() => console.log('[CreeveyWorker]:', `Browser session closed ${process.pid}`));
+    browser.quit();
   });
 
   if (viewport) {

src/utils.ts

@@ -117,13 +117,17 @@ export function subscribeOn(
 }
 
 export function shutdownWorkers(): void {
-  Object.values(cluster.workers)
-    .filter(isDefined)
-    .filter((worker) => worker.isConnected())
-    .forEach((worker) => {
-      const timeout = setTimeout(() => worker.kill(), 10000);
-      worker.send('shutdown');
-      worker.disconnect();
-      worker.on('disconnect', () => clearTimeout(timeout));
-    });
+  emitMessage<'shutdown'>('shutdown');
+  // NOTE Some workers exit on SIGINT, we need to wait a little to kill the remaining
+  setTimeout(() =>
+    Object.values(cluster.workers)
+      .filter(isDefined)
+      .filter((worker) => worker.isConnected())
+      .forEach((worker) => {
+        const timeout = setTimeout(() => worker.kill(), 10000);
+        worker.on('disconnect', () => clearTimeout(timeout));
+        worker.send('shutdown');
+        worker.disconnect();
+      }),
+  );
 }