Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapse the code package into jrpc2. #97

Merged
merged 1 commit into from
Mar 19, 2023
Merged

Conversation

creachadair
Copy link
Owner

After removing the registration hooks in #91, what is left of the code package is too small to deserve its own identity. Collapse the package into the root jrpc2 package.

  • Rename the code.FromError helper to jrpc2.ErrorCode.
  • Update documentation.

Updates #46.

After removing the registration hooks in #91, what is left of the code package
is too small to deserve its own identity. Collapse the package into the root
jrpc2 package.

- Rename the code.FromError helper to jrpc2.ErrorCode.
- Update documentation.

Updates #46.
@creachadair creachadair merged commit ef7b642 into main Mar 19, 2023
@creachadair creachadair deleted the mjf/collapse-code branch March 19, 2023 17:13
creachadair added a commit that referenced this pull request Mar 19, 2023
Documentation:
- 8628a62 server: clean up an obsolete comment
- 628f1a8 handler: fix a comment typo
- 9449abd handler: remove implementation details from docs (#96)
- 370c1eb Clean up package doc.
- cf1bb22 Clarify that Stop cancels running call handlers.

Cleanup:
- ce007de Clean up the rpc.serverInfo implementation. (#94)
- 2670c9f Construct the internal queue by value.

Breaking changes:
- ef7b642 Collapse the code package into jrpc2. (#97)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant