Replace idiosyncratic metrics collector with expvar. #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change removes the "metrics" package from the module and updates the existing metrics to use the standard expvar package instead. The package creates a shared *expvar.Map at initialization time, and populates expvar metrics for the existing server details (request counts, bytes read/written, active servers, etc.). This is a breaking change to the module API.
Also: Update Go toolchain to 1.18.
creachadair
added a commit
that referenced
this pull request
Oct 30, 2022
This release removes the idiosyncratic "metrics" collector and replaces its use with the standard "expvar" package (see #89). This is a breaking change to the module API. Packages that wish to attach custom metrics can now do so by calling the new jrpc2.ServerMetrics helper, which returns a *expvar.Map. The caller may add any metrics it wishes to this map, and they will be propagated into the ServerInfo value by the server. The caller is also responsible for publishing the map to a metrics collector (e.g., calling expvar.Publish or forwarding to Prometheus) if desired. Other changes in this release: - Update module dependencies - Remove usage of the "metrics" package from examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the "metrics" package from the module and updates the
existing metrics to use the standard expvar package instead. The package
creates a shared *expvar.Map at initialization time, and populates expvar
metrics for the existing server details (request counts, bytes read/written,
active servers, etc.).
This is a breaking change to the module API.
Updates #46.