handler: add an option to disallow array-based parameters #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
creachadair
force-pushed
the
mjf/disallow-array
branch
from
64aaa2c
to
ac49d54
Compare
creachadair
force-pushed
the
mjf/disallow-array
branch
from
9c52ded
to
ada7b95
Compare
creachadair
force-pushed
the
mjf/disallow-array
branch
from
ada7b95
to
e8e088a
Compare
creachadair
force-pushed
the
mjf/disallow-array
branch
from
e8e088a
to
d8d9723
Compare
2opremio
approved these changes
Apr 1, 2024
|
Any change of getting this merged soonish? I would like to be able to close stellar/soroban-rpc#13 |
Sure, I'm glad to merge it anytime. I was leaving it open to make sure you had a chance to test it before I put a release number on it. If you're content with the current status, I'll merge and tag it. |
Add a new AllowArray option to handler.FuncInfo controlling whether the decoder will allow array notation for struct arguments. The default is true, so that existing use is not affected. When true (the default), the decoder allows the arguments for a struct to be passed as a JSON array and maps the corresponding values to the struct fields in order of declaration. This is the existing behaviour. When false, the decoder reports an error for a struct-valued argument when the parameter value is an array. Updates #113
creachadair
force-pushed
the
mjf/disallow-array
branch
from
d8d9723
to
89f56f0
Compare
creachadair
added a commit
that referenced
this pull request
Apr 1, 2024
Maintenance: - go.mod: update module dependencies - .github: update setup-go to v5 - Use queue.Queue instead of mlink.Queue. Features: - handler: add an option to disallow array-based parameters (#114)
|
This is now tagged at and after release v1.2.0. |
|
Awesome. Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new AllowArray option to handler.FuncInfo controlling whether the decoder
will allow array notation for struct arguments. The default is true, so that
existing use is not affected.
When true (the default), the decoder allows the arguments for a struct to be
passed as a JSON array and maps the corresponding values to the struct fields
in order of declaration. This is the existing behaviour.
When false, the decoder reports an error for a struct-valued argument when the
parameter value is an array.
Updates #113