[e2e] Add test: OpenShfit story behind proxy

[jsliacan]

Depends on: PR #3417

We start proxy in Before hook of each scenario and remove it in the After hook of each scenario. This way all openshift stories should directly work behind proxy.

Testing

Run e2e tests (this is part of them). Or run only this feature with @linux && @story_openshift && @proxy tag.

[praveenkumar]

/hold

[jsliacan]

/unhold

[praveenkumar]

@jsliacan I don't think just removing this line is doing what you described in the commit log.

[jsliacan]

Oh great, I must've mingled the commits when rearranging after last changes. Thanks for noticing.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jsliacan. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• test/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[cfergeau]

This is almost a copy&paste from story_openshift.feature. It would be useful to have an indication of this in the commit log/in the file itself (as a reminder both have to be kept in sync). And some explanation why this is duplicated would not hurt (I guess reuse is hard with what we use for testing?)

[cfergeau]

/retest

[adrianriobo]

Indeed @cfergeau I think we should avoid the duplication, already discussed with @jsliacan, so we probably switch a bit the approach:

• We keep the simple proxy tests, so without knowing nothing about options on how to run tests, the default flow will cover the proxy setup.

• We will add a parameter on how to run the suite, so basically it will tell if we want to run everything with proxy, which basically means there will be an underneath logic on adding the proxy setup to the cluster on each spin of the cluster (this will allow us to run an in deep test of a cluster with a proxy setup)

[jsliacan]

Also, I asked on cucumber/godog about Examples (Outline) for the Background directive. We'll see what they say, maybe there's a way to I'm not seeing that they'll suggest and we can keep the setup transparent to the user and not duplicate things. I don't think they'll actually implement the feature.

cucumber/godog#567

Additionally, if you have suggestions about how to re-word my issue over there, I'm all ears. Thanks!

[gbraad]

how does this relate to #3684?

[praveenkumar]

/need-rebase

[openshift-merge-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@jsliacan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-crc	4b7af7e	link	true	/test e2e-crc
ci/prow/e2e-microshift-crc	4b7af7e	link	true	/test e2e-microshift-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[jsliacan]

I'm closing this for now as the changes in here aren't substantial to keep and we anyways agreed on a different approach than duplicating a feature file.