Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix label rename #121

Merged
merged 1 commit into from Dec 16, 2020
Merged

Fix label rename #121

merged 1 commit into from Dec 16, 2020

Conversation

jvalkeal
Copy link
Contributor

Tried to run action from my fork and these little changes worked well.

@codecov
Copy link

codecov bot commented Dec 16, 2020

Codecov Report

Merging #121 (e7098a7) into master (3fada34) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #121   +/-   ##
=======================================
  Coverage   60.13%   60.13%           
=======================================
  Files           2        2           
  Lines         148      148           
  Branches       22       22           
=======================================
  Hits           89       89           
  Misses         45       45           
  Partials       14       14           
Impacted Files Coverage Δ
src/labeler.ts 58.08% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fada34...e7098a7. Read the comment docs.

Copy link
Owner

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jvalkeal Please rebase and I make the review, thanks!

@jvalkeal
Copy link
Contributor Author

Not sure what that validate does as was is related to previous commit.

Copy link
Owner

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- Now using correct api fields, `current_name` vs `new_name`.
- Fixes crazy-max#120
Copy link
Owner

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@crazy-max crazy-max merged commit ad922a2 into crazy-max:master Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Label rename doesn't work
2 participants