CI/GHA: Run Windows tests on windows-2019 instead of windows-2022 #12344
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
the
windows-latest
image label on GHA effectively switched towindows-2022
1only recentlyon February 2, 2022 2. The original announcement happened on January 11, 2022: https://github.blog/changelog/2022-01-11-github-actions-jobs-running-on-windows-latest-are-now-running-on-windows-server-2022/On the
crash
repository, performance regressions have been observed with that. With crate/crash@11d77dcca8 in place, switching back towindows-2019
, the runtime of an individual test job on Windows decreased from 12 minutes to 6 minutes. It would be sweet to see corresponding improvements here as well.With kind regards,
Andreas.
Footnotes
https://github.com/actions/virtual-environments/issues/4856, see also Windows Server 2022 (20220330 update). ↩
Officially announced to have happened due March 6, 2022, it might well have been delayed and concluded only 12 days ago, as mentioned at https://github.com/actions/virtual-environments/issues/4856#issuecomment-1083192716. ↩