Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Update runtime dependencies across the board #794

Merged
merged 3 commits into from Dec 2, 2022

Conversation

amotl
Copy link
Member

@amotl amotl commented Dec 2, 2022

About

This patch bumps all runtime dependency packages to their most recent compatible patch releases.

Reproduce

# Baseline dependencies.
npm update bootstrap bootstrap-sass codemirror font-awesome jquery json3 oclazyload popper.js

# UI framework.
npm update @uirouter/angularjs angular angular-cookies angular-nvd3 angular-sanitize angular-translate angular-translate-loader-partial angular-translate-loader-static-files angular-translate-storage-cookie

More

After the build/test process croaked on something related to bootstrap-sass, 5ea784e was implemented after discovering a corresponding recommendation at twbs/bootstrap-sass#1224 (comment). Thanks, @AprilArcus.

npm update bootstrap bootstrap-sass codemirror font-awesome jquery json3 oclazyload popper.js
npm update @uirouter/angularjs angular angular-cookies angular-nvd3 angular-sanitize angular-translate angular-translate-loader-partial angular-translate-loader-static-files angular-translate-storage-cookie
SassError: Invalid CSS after "...point-max: math": expected expression (e.g. 1px, bold), was ".div($grid-float-br"
  from line 12 of app/styles/styles.scss
  >> $grid-float-breakpoint-max: math.div($grid-float-breakpoint - 1) !default;

     --------------------------------^

> This error appears to be due to the use of SassC instead of dart-sass.
> SassC wraps libsass, which does not support the math.div syntax. SassC
> and libsass are deprecated.
>
> I recommend you upgrade your sass compiler to an appropriate version.
>
> -- @AprilArcus, twbs/bootstrap-sass#1224 (comment)
@amotl amotl marked this pull request as ready for review December 2, 2022 13:48
@amotl amotl merged commit 074e56e into main Dec 2, 2022
@amotl amotl deleted the amo/update-dependencies-common branch December 2, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants