Add support for certificates in mysqldump #12596
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As it is right now, craft does not support setting the ssl attributes in the configuration it uses for mysqldump. Add support for this instead of having to use the really cumbersome method of overriding the backup command setting.
|
@angrybrad Fixed the code style error (space before parentheses) |
angrybrad
added a commit
that referenced
this pull request
Feb 3, 2023
Fixed a bug where Craft wasn’t respecting SSL database connection settings if they were specified.
|
Thanks for the PR @okolvik-avento! We cherry-picked your fix over to Craft 3 via #12612, and have merged it into |
This was referenced Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As it is right now, craft does not support setting the ssl attributes in the configuration it uses for mysqldump. Add support for this instead of having to use the really cumbersome method of overriding the backup command setting.
Related issues
#10351
#11753