sync PC name comments from freshly grabbed DB data #12581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ame-comments-sync-v3 sync PC name comments from freshly grabbed DB data
…6-project-config-name-comments-sync # Conflicts: # CHANGELOG.md # src/services/ProjectConfig.php
brandonkelly
deleted the
bugfix/12576-project-config-name-comments-sync
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
At the moment, if you add a new, e.g. field or change its name, the name comment won’t be updated in this round of writing data to yaml files. It will be added on the next write to yaml (it will always lag one write action behind).
This PR changes that behaviour so that each time we write to yaml, we use freshly grabbed DB-stored config and use that data to get
uid/namemappings for comments.Related issues
#12576