enable/use gofumpt #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While at it, remove the comment saying that version has to be specified without patch number -- this is no longer true (as of a few years back). Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
This is the result of for f in $(git ls-files | grep .go | grep -v ^vendor/); do gofumpt -w $f; done using gofumpt v0.5.0 (go1.20.2). Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Impose somewhat stricter formatting rules. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
|
Golangci bump is here because older golangci errors out on an unrelated code. From https://github.com/cpuguy83/go-md2man/actions/runs/4726984088: |
cpuguy83
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gofumpt is a stricter superset of gofmt, enabling some more rules to make the code better (more readable etc).
This PR fixes the existing code with gofumpt, and enables gofumpt linter in CI (to check future PRs).