New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for MarkDown headings formatted as "COMMAND(1) ..." #65
Conversation
9a351bb
to
5e71be8
Compare
5e71be8
to
a546ea0
Compare
hm, actually, more may be needed for cobra, as I think it's using |
1302d74
to
b20a5ed
Compare
extensions := params.extensions | ||
if extensions == 0 { | ||
extensions = renderer.extensions | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, after digging why it didn't work with the % xxx
pandoc headers, this seemed to be the problem; the tests were running without the blackfriday.Titleblock
extension enabled, so blackfriday was not converting them to H1 blocks.
@cpuguy83 @tianon this should be ready to go now. I noticed that v1 would convert this input; % DOCKER(1) Docker User Manuals
% Docker Community
% JUNE 2014 To:
And v2 (with this change applied) converts it to:
As a result, the words were split, and didn't show up correctly when viewing the man page; With V1:
With V2:
I pushed another commit to remove newlines, and to quote each line. It's a bit ugly, so better suggestions welcome |
3fea185
to
21c4566
Compare
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
21c4566
to
f92de22
Compare
Is this still needed? |
I guess with the fix in Cobra, it's no longer needed; let me close this one (I'll keep the branch for now, in case we find we still need it) |
relates to spf13/cobra#1049 and docker/docker-ce-packaging#502