Fix trailing newline in code blocks #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpuguy83
force-pushed
the
fix_codeblock_newline
branch
from
a74886b
to
d87a980
Compare
kolyshkin
reviewed
Feb 5, 2024
md2man/roff_test.go
Outdated
| ".nh\n\n.EX\necho foo\n\n.EE\n", | ||
| ".nh\n\n.EX\necho foo\n.EE\n", | ||
|
|
||
| // make sure we litteral new lines surrounding in the markdown block are preserved as they are intentional |
There was a problem hiding this comment.
s/we litteral/the literal/
|
Overall LGTM, but let me try that on some more inputs first. |
cpuguy83
force-pushed
the
fix_codeblock_newline
branch
from
d87a980
to
d3d5f33
Compare
|
Hi! Thank you very much for this module. I'd like to ask when this PR will be merged? |
cpuguy83
force-pushed
the
fix_codeblock_newline
branch
from
d3d5f33
to
4ab80e5
Compare
Given this input: > ``` > some code > ``` We were adding an additional newline character before the code close tag even though the code block by definition already includes that newline. e.g., blackfriday is hadning us `some code\n` as the literal content of the code block. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
cpuguy83
force-pushed
the
fix_codeblock_newline
branch
from
4ab80e5
to
fd6bc09
Compare
|
v2.0.4 includes this fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given this input:
We were adding an additional newline character before the code close tag even though the code block by definition already includes that newline.
e.g., blackfriday is hadning us
some code\nas the literal content of the code block.fixes #47