Fix escape characters for content with newline #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given an input like so: ```markdown 'foo' 'bar' ``` We should be escaping both opening `'`. Before this change only the first was escaped because we only look at the first character of a `[]byte` and did not account for newlines. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
cpuguy83
force-pushed
the
fix_newline_escape
branch
from
245191c
to
094dfca
Compare
|
Sorry I just force pushed the wrong thing to the branch. |
cpuguy83
force-pushed
the
fix_newline_escape
branch
from
094dfca
to
f0c6142
Compare
|
@kolyshkin Care to take a look at this one as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given an input like so:
We should be escaping both opening
'.Before this change only the first was escaped because we only look at the first character of a
[]byteand did not account for newlines.Fixes #110