Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use native package managers for linux runner #116

Merged
merged 2 commits into from
Oct 26, 2022
Merged

Conversation

shenxianpeng
Copy link
Collaborator

@shenxianpeng shenxianpeng commented Oct 25, 2022

Fix #106

Right now this only supports Linux runner

Why do not support macOS and windows runner because the following reasons:

on macOS, brew only supports a few versions of clang-format and does not support clang-tidy right now

Run if [[ "macOS"  == "Linux" ]]; then
Warning: No available formula with the name "clang-tidy". Did you mean clang-format?
==> Searching for similarly named formulae...
This similarly named formula was found:

on windows chocolatey support installing both clang-format and clang-tidy but the version is different with user input. for example when the user input 13 in the cpp-linter.yml etc, we need to match this version from 13 to 13.0.1 otherwise can not find and install clang 13 on windows. we also need to match for other versions if we support them, but it would be best to do it like in a setup-action.sh script file. right now I think it should be enough we only support linux.

@shenxianpeng shenxianpeng changed the title use native package for linux runner use native package managers for linux runner Oct 26, 2022
Copy link
Collaborator

@2bndy5 2bndy5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for researching this more (and doing the implementation in action.yml). I agree other OS support is spotty for package managers, but that's because the ones available aren't actually shipped with the OS (aka non-native).

The only edge case I can think of with this change is if the version specified isn't available in the updated PPAs that apt-get update fetches. For example, LLVM may release v16, but the PPA may not immediately provide v16... I'm confident we could cross that bridge if we need to in the future though.

@2bndy5
Copy link
Collaborator

2bndy5 commented Oct 26, 2022

Oops, it looks like ubuntu 20.04 runner doesn't have v13 or v14 in the PPA. I think ubuntu 22.04 will have these, but that hasn't been made the default (ubuntu-latest) yet.

@shenxianpeng
Copy link
Collaborator Author

Yes. v13 or v14 not in ubuntu 20.04 yet : (

@2bndy5
Copy link
Collaborator

2bndy5 commented Oct 26, 2022

they will be soon though... actions/runner-images#6399

@shenxianpeng
Copy link
Collaborator Author

cool, subscribed to that issue.

I'd like to release this change now (or may also support v13 and v14 by adding new repo like I did here if needed.)

@2bndy5
Copy link
Collaborator

2bndy5 commented Oct 26, 2022

yeah, I'm ok with moving forward on this.

@shenxianpeng shenxianpeng merged commit 0155b5f into main Oct 26, 2022
@shenxianpeng shenxianpeng deleted the use-native-package branch October 26, 2022 03:22
@shenxianpeng
Copy link
Collaborator Author

Based on https://semver.org/, I guess we might treat this change as a feature, so the version will be v2.2.0, not v2.1.5. any thoughts about versioning

@2bndy5
Copy link
Collaborator

2bndy5 commented Oct 26, 2022

that sounds right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use native package managers
2 participants