Faster start of RE #59
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any progress on that? |
|
Can you show benchmarks here? |
|
Sorry, I did not save it
…On Tue, Sep 6, 2022, 3:58 AM Ofek Lev ***@***.***> wrote:
Can you show benchmarks here?
—
Reply to this email directly, view it on GitHub
<#59 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AARGSBY6EZYPTMMP35OPC4LV42JJ3ANCNFSM573P7LQA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Then how can one determine whether or not to accept this PR? |
|
Well it's up to a reviewer to make any tests they want or need
…On Tue, Sep 6, 2022, 7:17 AM Ofek Lev ***@***.***> wrote:
Then how can one determine whether or not to accept this PR?
—
Reply to this email directly, view it on GitHub
<#59 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AARGSB3U2K4IWNXK7QLAPO3V43AVNANCNFSM573P7LQA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Hi @excitoon, do you have a benchmark comparing the change to the original? |
|
Yes, I had. I ran it on ClickHouse source code with all submodules
recursively synced. It showed about 5% improvement.
But you have to reproduce it yourself to be 100% sure
…On Thu, Sep 8, 2022, 5:27 AM Caleb P. Burns ***@***.***> wrote:
Hi @excitoon <https://github.com/excitoon>, do you have a benchmark
comparing the change to the original?
—
Reply to this email directly, view it on GitHub
<#59 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AARGSB4CR3ZM3M3NEHSCXILV5FFJXANCNFSM573P7LQA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress on #38