Skip to content

Commit

Permalink
core/rawdb: fix db commands (ethereum#24540)
Browse files Browse the repository at this point in the history
  • Loading branch information
rjl493456442 authored and cp-wjhan committed Nov 16, 2022
1 parent 123b119 commit 3a4f89f
Showing 1 changed file with 9 additions and 2 deletions.
11 changes: 9 additions & 2 deletions core/rawdb/freezer_table.go
Expand Up @@ -153,8 +153,15 @@ func newTable(path string, name string, readMeter metrics.Meter, writeMeter metr
if err != nil {
return nil, err
}
// Will fail if the table is legacy(no metadata)
meta, err = openFreezerFileForReadOnly(filepath.Join(path, fmt.Sprintf("%s.meta", name)))
// TODO(rjl493456442) change it to read-only mode. Open the metadata file
// in rw mode. It's a temporary solution for now and should be changed
// whenever the tail deletion is actually used. The reason for this hack is
// the additional meta file for each freezer table is added in order to support
// tail deletion, but for most legacy nodes this file is missing. This check
// will suddenly break lots of database relevant commands. So the metadata file
// is always opened for mutation and nothing else will be written except
// the initialization.
meta, err = openFreezerFileForAppend(filepath.Join(path, fmt.Sprintf("%s.meta", name)))
if err != nil {
return nil, err
}
Expand Down

0 comments on commit 3a4f89f

Please sign in to comment.