Allow to interact with a NextCloud via WebDAV #4392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cballevre
reviewed
May 13, 2024
NextCloud is sending application/octet-stream for files in WebDAV. We are now infering the mime/class from the filename.
cballevre
reviewed
May 16, 2024
taratatach
reviewed
May 20, 2024
Comment on lines
+144
to
+147
| ext := filepath.Ext(oldPath) | ||
| base := strings.TrimSuffix(oldPath, ext) | ||
| suffix := inst.Translate("File copy Suffix") | ||
| newPath = fmt.Sprintf("%s (%s)%s", base, suffix, ext) |
There was a problem hiding this comment.
If I'm not mistaken, this means we can't make multiple copy requests for the same file without passing a Name as all copies would have the same suffix and the request to NC will fail with a 412 response code.
Can't we use the same mechanism we use for copies on our side?
There was a problem hiding this comment.
You are correct. Technically, we can use the same mechanism, but NextCloud is slow (a few hundred milliseconds per call), and this mechanism adds more calls, and will make things slower. I don't really know if it is a good idea or not to use it here.
There was a problem hiding this comment.
I understand. Let's see if we really need it then.
taratatach
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.