Handle errors in case of issue during the account encryption #3828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nono
reviewed
Mar 8, 2023
|
The integration tests are failing when creating an account, with a 500 error. Can you look at it? |
I try but I don't find any info inside the logs and I try to replicate the error in local but the script still failing at some random place, I need to debug it first... I will create an issue in order to discuss this subject without polluting this PR Edit: #3830 |
At the moment if an error append during encryption the field is skipped and the error is ignored. As we don't want to loose any data it seem better to return an explicit error.
|
Can't find a way to debug this issue... @nono a little help would be really nice 🥺 |
|
Sorry, I have other priorities for the moment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.