Flag initialisation #948
Merged
Flag initialisation #948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptbrowne
force-pushed
the
init-flags-dom-remote
branch
from
abfaa05
to
be49932
Compare
edas
reviewed
Feb 6, 2020
packages/cozy-flags/src/flag.js
Outdated
| * Enables a list of flags | ||
| * | ||
| * Supports passing either | ||
| * - an array containing flag names (in this case, flag values will be true) |
There was a problem hiding this comment.
Je trouve les deux prototypes trop différents.
J'aurais compris :
- soit un nom soit une liste de noms
- soit un objet nom/valeur soit un tableau d'objet nom/valeur
Là tu croises les possibilités et ça me gêne. Ca mérite probablement deux fonctions séparées
|
|
||
| const store = new FlagStore() | ||
| export const getTemplateData = attr => { |
There was a problem hiding this comment.
Cette fonction est toujours là pour les flags, pourquoi ne pas fixer la valeur à "flags" ? A-t-on besoin du paramétrage ?
There was a problem hiding this comment.
Je vois pas l'avantage de rigidifier getTemplateData alors qu'en l'état elle fonctionne et est flexible.
Flags are initialized from nodes with cozy-flags or cozy-data
ptbrowne
force-pushed
the
init-flags-dom-remote
branch
from
57bd0da
to
1424a5b
Compare
Co-Authored-By: Éric D. <15271+edas@users.noreply.github.com>
ptbrowne
force-pushed
the
init-flags-dom-remote
branch
from
ef217ef
to
85000f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cozy-flagsnow supports initialisation eitherA CozyClient plugin can be attached to a CozyClient instance for
automatic initialisation and reset of flags on login/logout.
New APIs
async flags.initialise(): initialises flags from DOM or remote (remote only if DOM not possible)client.registerPlugin(flags.plugin)