Skip to content

Commit

Permalink
Fixes jetty#8591: Indicate units of HttpClient properties.
Browse files Browse the repository at this point in the history
  • Loading branch information
cowwoc committed Oct 18, 2022
1 parent 5a9f3fb commit 12ae588
Showing 1 changed file with 7 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ public class HttpClient extends ContainerLifeCycle
private boolean followRedirects = true;
private int maxConnectionsPerDestination = 64;
private int maxRequestsQueuedPerDestination = 1024;
private int requestBufferSize = 4096;
private int requestBufferSizeInBytes = 4096;
private int responseBufferSize = 16384;
private int maxRedirects = 8;
private long addressResolutionTimeout = 15000;
Expand Down Expand Up @@ -906,21 +906,21 @@ public void setMaxRequestsQueuedPerDestination(int maxRequestsQueuedPerDestinati
@ManagedAttribute("The request buffer size")
public int getRequestBufferSize()
{
return requestBufferSize;
return requestBufferSizeInBytes;
}

/**
* @param requestBufferSize the size of the buffer used to write requests
* @param requestBufferSizeInBytes the size of the buffer (in bytes) used to write requests
*/
public void setRequestBufferSize(int requestBufferSize)
public void setRequestBufferSize(int requestBufferSizeInBytes)
{
this.requestBufferSize = requestBufferSize;
this.requestBufferSizeInBytes = requestBufferSizeInBytes;
}

/**
* @return the size of the buffer used to read responses
* @return the size of the buffer (in bytes) used to read responses
*/
@ManagedAttribute("The response buffer size")
@ManagedAttribute("The response buffer size in bytes")
public int getResponseBufferSize()
{
return responseBufferSize;
Expand Down

0 comments on commit 12ae588

Please sign in to comment.