Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Use signing from web3 crate #326

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - Use signing from web3 crate #326

wants to merge 2 commits into from

Conversation

nlordell
Copy link
Contributor

@nlordell nlordell commented May 26, 2020 •
edited

This PR uses signing that was upstreamed to the web3 crate.

Closes #14

Test Plan

SIgned transaction tests still pass!

@nlordell nlordell requested a review from a team May 26, 2020 13:45
bh2smith
bh2smith approved these changes May 26, 2020
View reviewed changes
Copy link
Contributor

@bh2smith bh2smith left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, Looks much cleaner!

fleupold
fleupold approved these changes May 26, 2020
View reviewed changes
Copy link
Contributor

@fleupold fleupold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, ecosystem work paying off

@nlordell nlordell changed the base branch from async-tx-7 to master May 27, 2020 08:58
@nlordell
Copy link
Contributor Author

bors r+

bors bot pushed a commit that referenced this pull request May 27, 2020
Use signing from web3 crate (#326)
19e408b 
This PR uses signing that was upstreamed to the `web3` crate.

Closes #14 

### Test Plan

SIgned transaction tests still pass!
@bors
Copy link

bors bot commented May 27, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title Use signing from web3 crate [Merged by Bors] - Use signing from web3 crate May 27, 2020
@bors bors bot closed this May 27, 2020
@bors bors bot deleted the web3-sign branch May 27, 2020 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fleupold fleupold fleupold approved these changes

@e00E e00E e00E approved these changes

@bh2smith bh2smith bh2smith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move signing functionality from ethcontract upstream.
4 participants
@nlordell @fleupold @e00E @bh2smith