Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move signing functionality from ethcontract upstream. #14

Closed
nlordell opened this issue Oct 29, 2019 · 2 comments
Closed

Move signing functionality from ethcontract upstream. #14

nlordell opened this issue Oct 29, 2019 · 2 comments
Labels
cleanup Clean up the code base and remove some technical debt

Comments

@nlordell
Copy link
Contributor

nlordell commented Oct 29, 2019 •
edited

Offline signing support has recently been added to rust-web3. We should use it instead of our custom code.
@nlordell nlordell added the enhancement New feature or request label Oct 29, 2019
@nlordell
Copy link
Contributor Author

nlordell commented Nov 6, 2019

Pull request is here tomusdrw/rust-web3#279

@nlordell nlordell mentioned this issue Jan 20, 2020
Closed
3 tasks
@nlordell
Copy link
Contributor Author

nlordell commented Feb 5, 2020

New PR with license compatible crate: tomusdrw/rust-web3#325

@nlordell nlordell added cleanup Clean up the code base and remove some technical debt and removed enhancement New feature or request labels May 26, 2020
@nlordell nlordell mentioned this issue May 26, 2020
Closed
@bors bors bot closed this as completed in 19e408b May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup Clean up the code base and remove some technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Merged by Bors] - Use signing from web3 crate cowprotocol/ethcontract-rs
1 participant
@nlordell