Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes assembly resolution so it scans the module directory as well. #23

Merged

Conversation

pms1969
Copy link
Contributor

@pms1969 pms1969 commented Apr 3, 2018

The fix works, and is only 2 additional lines.

What I've struggled to do is understand what conditions are required to trigger this. Almost all other assemblies that in our solution don't even try and resolve other assemblies when being re-written. However, 2 do, and this PR fixes the issue with them. See: (#21)

@coveralls
Copy link

Pull Request Test Coverage Report for Build #38

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • 12 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 81.319%

Files with Coverage Reduction New Missed Lines %
/src/coverlet.core/Instrumentation/Instrumenter.cs 12 77.27%
Totals Coverage Status
Change from base Build #36: 0.1%
Covered Lines: 296
Relevant Lines: 364

💛 - Coveralls

Copy link
Collaborator

@tonerdo tonerdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@tonerdo tonerdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tonerdo tonerdo merged commit dedede7 into coverlet-coverage:master Apr 3, 2018
@pms1969 pms1969 mentioned this pull request Apr 4, 2018
NorekZ pushed a commit to NorekZ/coverlet that referenced this pull request Nov 8, 2018
…esolution

Fixes assembly resolution so it scans the module directory as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants