Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add total line coverage for badge generators #180

Merged
merged 2 commits into from Sep 15, 2018

Conversation

kolipka
Copy link
Contributor

@kolipka kolipka commented Aug 22, 2018

Should solve #178 and #148 with regex:
/Total.*?([0-9]{1,3})(,[0-9]{1,2})?%/

@pimmerks
Copy link

Might also want to show the average of branch and method coverage like in: #104 & #123

Total Line: 100%
Total Branch: 100%
Total Method: 100%

Something like this maybe?

@kolipka
Copy link
Contributor Author

kolipka commented Aug 25, 2018

no problem :)

Copy link
Collaborator

@tonerdo tonerdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kolipka LGTM! Please paste a copy of the terminal output with this change. Thanks!

@kolipka
Copy link
Contributor Author

kolipka commented Aug 27, 2018

C:\projects\coverlet\test\coverlet.core.tests\coverage.opencover.xml'

67
68 +------------------+--------+--------+--------+
69 | Module | Line | Branch | Method |
70 +------------------+--------+--------+--------+
71 | coverlet.core | 90.8% | 86.2% | 93.4% |
72 +------------------+--------+--------+--------+
73 | coverlet.tracker | 0% | 0% | 0% |
74 +------------------+--------+--------+--------+
75
76
77 Total Line 89.7%
78 Total Branch 84.6%
79 Total Method 91.7%

@Taturevich
Copy link

When this pr will be merged?

@tonerdo tonerdo merged commit 47206b0 into coverlet-coverage:master Sep 15, 2018
NorekZ pushed a commit to NorekZ/coverlet that referenced this pull request Nov 8, 2018
Add total line coverage for badge generators
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants