Performance improvements #134
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,70 +2,61 @@ | |
| using System.Collections.Generic; | ||
| using System.Diagnostics.CodeAnalysis; | ||
| using System.IO; | ||
|
|
||
| namespace Coverlet.Tracker | ||
| { | ||
| public static class CoverageTracker | ||
| { | ||
| private static Dictionary<string, Dictionary<string, int>> _events; | ||
|
|
||
| [ExcludeFromCodeCoverage] | ||
| static CoverageTracker() | ||
| { | ||
| _events = new Dictionary<string, Dictionary<string, int>>(); | ||
| AppDomain.CurrentDomain.ProcessExit += new EventHandler(CurrentDomain_ProcessExit); | ||
| AppDomain.CurrentDomain.DomainUnload += new EventHandler(CurrentDomain_ProcessExit); | ||
| } | ||
|
|
||
| [ExcludeFromCodeCoverage] | ||
| public static void MarkExecuted(string file, string evt) | ||
| { | ||
| lock (_events) | ||
| { | ||
| if (!_events.TryGetValue(file, out var fileEvents)) | ||
| { | ||
| fileEvents = new Dictionary<string, int>(); | ||
| _events.Add(file, fileEvents); | ||
| } | ||
|
|
||
| if (!fileEvents.TryGetValue(evt, out var count)) | ||
| { | ||
| fileEvents.Add(evt, 1); | ||
| } | ||
| else if (count < int.MaxValue) | ||
|
There was a problem hiding this comment. What happens if There was a problem hiding this comment. I grabbed this code (but I see I changed the condition slightly) from the former site of the hit counting: I doubt that anyone who gets 2G hits on a line cares much if the counter stops then. :) |
||
| { | ||
| fileEvents[evt] = count + 1; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| [ExcludeFromCodeCoverage] | ||
| public static void CurrentDomain_ProcessExit(object sender, EventArgs e) | ||
| { | ||
| lock (_events) | ||
| { | ||
| foreach (var files in _events) | ||
| { | ||
| using (var fs = new FileStream(files.Key, FileMode.Create)) | ||
| using (var sw = new StreamWriter(fs)) | ||
| { | ||
| foreach (var evt in files.Value) | ||
| { | ||
| sw.WriteLine($"{evt.Key},{evt.Value}"); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| _events.Clear(); | ||
| } | ||
| } | ||
| } | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| using coverlet.testsubject; | ||
| using Xunit; | ||
|
|
||
| namespace coverlet.core.performancetest | ||
| { | ||
| /// <summary> | ||
| /// Test the performance of coverlet by running a unit test that calls a reasonably big and complex test class. | ||
| /// Enable the test, compile, then run the test in the command line: | ||
| /// <code> | ||
| /// dotnet test -p:CollectCoverage=true -p:CoverletOutputFormat=opencover test/coverlet.core.performa ncetest/ | ||
| /// </code> | ||
| /// </summary> | ||
| public class PerformanceTest | ||
| { | ||
| [Theory(Skip = "Only enabled when explicitly testing performance.")] | ||
| [InlineData(150)] | ||
| public void TestPerformance(int iterations) | ||
| { | ||
| var big = new BigClass(); | ||
|
|
||
| for (var i = 0; i < iterations; i++) | ||
| { | ||
| big.Do(i); | ||
| } | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line was the core of the bottleneck (together with the similar line doing
document.Branches.Firstabove. Having the lines in a list means that it finding the correct line for an event will have to search throughn/2items of thenitems in the list on average. The number of events in a test can be described askn, wherekis the number of times the average line is executed during the test.Putting that together means that processing all events in the test will take
(k/2) * n^2operations. In complexity theory the factor is not interesting since whenngets big, the value ofkis irrelevant, so the time complexity of this operation is expressed asO(n^2)in the big-O notation, i.e. quadratic time complexity.