Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues #29 & #95 #104

Merged
merged 3 commits into from Jun 9, 2018
Merged

Issues #29 & #95 #104

merged 3 commits into from Jun 9, 2018

Conversation

StephenMP
Copy link
Contributor

Issues #29 & #95 : Displays the average coverage % for all coverage types

@codecov
Copy link

codecov bot commented May 20, 2018

Codecov Report

Merging #104 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #104   +/-   ##
=======================================
  Coverage   98.91%   98.91%           
=======================================
  Files          15       15           
  Lines        1378     1378           
=======================================
  Hits         1363     1363           
  Misses         15       15

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 883d1f7...6dccea3. Read the comment docs.

@StephenMP
Copy link
Contributor Author

Interesting that run two different times, codecov reports two different results...

@StephenMP
Copy link
Contributor Author

Made a benign whitespace change to get the build process to re-run and fix Codecov issues. @tonerdo let me know if there's anything I need to do.

@tonerdo
Copy link
Collaborator

tonerdo commented May 24, 2018

@StephenMP no need. Will take a look once I get the chance

@tonerdo
Copy link
Collaborator

tonerdo commented May 26, 2018

Hiya @StephenMP Can I please see a screenshot of the final output. Also, I have my reservations about this feature considering the 2.0 update simply compares each assembly's coverage against the threshold instead of the average coverage

@StephenMP
Copy link
Contributor Author

@tonerdo

The final output looks like the following

Starting test execution, please wait...

  Total tests: 87. Passed: 87. Failed: 0. Skipped: 0.
  Test Run Successful.
  Test execution time: 9.2234 Seconds

  Calculating coverage result...
    Generating report 'path\to\coverage.xml'

  +---------------+--------+--------+--------+
  | Module        | Line   | Branch | Method |
  +---------------+--------+--------+--------+
  | coverlet.core | 90.3%  | 85.5%  | 94.1%  |
  +---------------+--------+--------+--------+

  +---------+--------+--------+--------+
  |         | Line   | Branch | Method |
  +---------+--------+--------+--------+
  | Average | 90.3%  | 85.5%  | 94.1%  |
  +---------+--------+--------+--------+

If you have your reservations, that's fine, I was just adding something suggested by two open tickets. If you don't want to include it you can close the pull request and the tickets 😄

@basilfx
Copy link

basilfx commented Jun 7, 2018

I would love to have this averaging feature.

In my solution I have unit tests and integration tests over multiple projects. Since these tests complement each other, it makes more sense to look at the average coverage, instead of the lowest coverage.

@tonerdo
Copy link
Collaborator

tonerdo commented Jun 9, 2018

Well I'm on board then

@tonerdo tonerdo merged commit d40b2d4 into coverlet-coverage:master Jun 9, 2018
NorekZ pushed a commit to NorekZ/coverlet that referenced this pull request Nov 8, 2018
mburumaxwell pushed a commit to faluapp/falu-dotnet that referenced this pull request Jun 12, 2021
Bumps [coverlet.collector](https://github.com/coverlet-coverage/coverlet) from 1.3.0 to 3.0.1.

#Release notes

*Sourced from [coverlet.collector's releases](https://github.com/coverlet-coverage/coverlet/releases).*

> ## v3.0.0
> * [#131](coverlet-coverage/coverlet#131) makes a slight change to the Coverlet JSON format
> * 807f7b1bd5bea8158ffff343d5511cd16e0da9a0 uses a separate `coverlet.tracker` assembly to hold tracking code
> * [#128](coverlet-coverage/coverlet#128) adds support for assemblies with `.exe` extension
> * a1f18b4156374f3398d704e898ec58c7c6c64bf8 improves identifying compiler generated types
> * [#134](coverlet-coverage/coverlet#134) adds considerable coverage tracking performance improvements
>
> ## v2.0.1
> * [#102](coverlet-coverage/coverlet#102) fixes issues with NUNIT3 Test adapter ([#101](coverlet-coverage/coverlet#101))
> * [#104](coverlet-coverage/coverlet#104) shows overall averages as part of final console output
> * [#112](coverlet-coverage/coverlet#112) adds support for standard `ExcludeFromCodeCoverage` attribute to specify types and methods to exclude from code coverage. Deprecates `ExcludeFromCoverage` attribute
> * coverlet-coverage/coverlet@7f190e4 prevents Opencover and Cobertura output generated at the same time from overwriting each other ([#111](coverlet-coverage/coverlet#111))
> * [#116](coverlet-coverage/coverlet#116) strongly signs the Coverlet assembly and aims to fix [#40](coverlet-coverage/coverlet#40)
>
> ## v2.0.0
> * [#78](coverlet-coverage/coverlet#78) adds support for generating multiple report formats in a single run
> * [#73](coverlet-coverage/coverlet#73) improves branch coverage support and output formats*
> * coverlet-coverage/coverlet@d2effb3 shows method coverage in summary output
> * [#88](coverlet-coverage/coverlet#88) improves disk usage by using gzip compression
> * [#93](coverlet-coverage/coverlet#93) adds `ThresholdType` property that allows you to specify the coverage type to apply the `Threshold` property to
> * coverlet-coverage/coverlet@ebedd70 renames `Exclude` property to `ExcludeByFile`*
> * coverlet-coverage/coverlet@9ed0864 supports using filter expressions to exclude assemblies, namespaces or types. Uses the `Exclude` property*
> * [#99](coverlet-coverage/coverlet#99) adds improvements to evaluation of filter expressions
>
> `*` - Backwards incompatible change

#Commits

- See f...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants