New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add e2e smoke tests for headless-ssr utils #3093
Conversation
Dependency ReviewThe following issues were found:
License Issuespackage-lock.json
packages/samples/headless-ssr/package.json
Allowed Licenses: 0BSD, Apache-2.0, Apache-2.0 AND MIT, Apache-2.0 AND BSD-3-Clause AND Python-2.0, Beerware, BlueOak-1.0.0, BSD-1-Clause, BSD-2-Clause, BSD-2-Clause-Patent, BSD-2-Clause-Views, BSD-2-Clause AND MIT, BSD-3-Clause, BSD-3-Clause-Attribution, BSD-3-Clause-Clear, BSL-1.0, CC-BY-3.0, CC-BY-4.0, CC0-1.0, CNRI-Python, curl, HPND, IBM-pibs, ImageMagick, ISC, JSON, MIT, MIT-0, MIT AND Python-2.0, MIT-advertising, mpi-permissive, NCSA, ODC-By-1.0, PDDL-1.0, Plexus, PostgreSQL, PSF-2.0, Python-2.0, Python-2.0.1, SAX-PD, Unlicense, UPL-1.0, W3C, Wsuipa, WTFPL, X11, X11-distribute-modifications-variant, Xerox, Zlib, ZPL-2.1 Scanned Manifest Filespackage-lock.json
packages/samples/headless-ssr/package.json
|
Pull Request Report PR Title ✅ Title follows the conventional commit spec. Bundle Size
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look nice!
Wondering how we should proceed regarding Cypress:
- use the same version as the other packages but then have another package to update when we do the update batch
- use the latest version and saves one update, but be out-of-sync with the other package, causing us to install cypress twice
I personally really don't mind either way, I don't think the differences are gonna be that significant. |
to workaround err UND_ERR_REQ_CONTENT_LENGTH_MISMATCH https://coveord.atlassian.net/browse/KIT-2643
to fix Error: Action failed. Missing package manager lockfile. https://coveord.atlassian.net/browse/KIT-2643
Check before merging
Next CI cache is being usedNext Cache needs to be moved to root for GH cache action to work. Can revisit when next build times are significant.https://coveord.atlassian.net/browse/KIT-2643