Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add e2e smoke tests for headless-ssr utils #3093

Merged
merged 85 commits into from Aug 11, 2023

Conversation

mrrajamanickam-coveo
Copy link
Contributor

@mrrajamanickam-coveo mrrajamanickam-coveo commented Aug 8, 2023

  • Add e2e cypress smoke tests using the headless-ssr sample page
    • Add a corresponding new GH action to run these tests
  • Modify sample page to include a timestamp
    • This is then parsed by the tests to verify the page is rendered in both SSR and CSR
image

Check before merging

https://coveord.atlassian.net/browse/KIT-2643

@github-actions
Copy link

github-actions bot commented Aug 8, 2023

Dependency Review

The following issues were found:
  • ✅ 0 vulnerable package(s)
  • ✅ 0 package(s) with incompatible licenses
  • ✅ 0 package(s) with invalid SPDX license definitions
  • ⚠️ 4 package(s) with unknown licenses.
See the Details below.

License Issues

package-lock.json

PackageVersionLicenseIssue Type
@types/react18.2.20NullUnknown License
@types/node20.4.9NullUnknown License

packages/samples/headless-ssr/package.json

PackageVersionLicenseIssue Type
@types/react18.2.20NullUnknown License
@types/node20.4.9NullUnknown License
Allowed Licenses: 0BSD, Apache-2.0, Apache-2.0 AND MIT, Apache-2.0 AND BSD-3-Clause AND Python-2.0, Beerware, BlueOak-1.0.0, BSD-1-Clause, BSD-2-Clause, BSD-2-Clause-Patent, BSD-2-Clause-Views, BSD-2-Clause AND MIT, BSD-3-Clause, BSD-3-Clause-Attribution, BSD-3-Clause-Clear, BSL-1.0, CC-BY-3.0, CC-BY-4.0, CC0-1.0, CNRI-Python, curl, HPND, IBM-pibs, ImageMagick, ISC, JSON, MIT, MIT-0, MIT AND Python-2.0, MIT-advertising, mpi-permissive, NCSA, ODC-By-1.0, PDDL-1.0, Plexus, PostgreSQL, PSF-2.0, Python-2.0, Python-2.0.1, SAX-PD, Unlicense, UPL-1.0, W3C, Wsuipa, WTFPL, X11, X11-distribute-modifications-variant, Xerox, Zlib, ZPL-2.1

Scanned Manifest Files

package-lock.json
  • @eslint-community/regexpp@4.5.1
  • @eslint-community/regexpp@4.6.2
  • @eslint/eslintrc@2.1.1
  • @eslint/js@8.46.0
  • @next/eslint-plugin-next@13.4.13
  • @types/node@20.4.9
  • @types/node@16.18.40
  • @types/react@18.2.20
  • commander@6.2.1
  • cypress@12.17.3
  • cypress-real-events@1.10.0
  • cypress-web-vitals@4.0.1
  • eslint@8.46.0
  • eslint-config-next@13.4.13
  • eslint-plugin-react@7.33.1
  • eslint-scope@7.2.2
  • eslint-visitor-keys@3.4.2
  • minimist@1.2.8
  • prettier@3.0.1
  • semver@7.5.4
  • @eslint-community/regexpp@4.5.1
  • @eslint/eslintrc@2.1.0
  • @eslint/js@8.44.0
  • @next/eslint-plugin-next@13.4.12
  • @types/node@20.4.5
  • @types/react@18.2.17
  • @typescript-eslint/parser@5.62.0
  • @typescript-eslint/scope-manager@5.62.0
  • @typescript-eslint/types@5.62.0
  • @typescript-eslint/typescript-estree@5.62.0
  • @typescript-eslint/visitor-keys@5.62.0
  • eslint@8.45.0
  • eslint-config-next@13.4.12
  • eslint-plugin-react@7.33.0
  • eslint-scope@7.2.1
packages/samples/headless-ssr/package.json
  • @types/node@20.4.9
  • @types/react@18.2.20
  • cypress@12.17.3
  • cypress-web-vitals@4.0.1
  • eslint@8.46.0
  • @types/node@20.4.5
  • @types/react@18.2.17
  • eslint@8.45.0

@github-actions
Copy link

github-actions bot commented Aug 8, 2023

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 181.7 181.7 0
search 342.6 342.6 0
insight 296.6 296.6 0
product-listing 285.5 285.5 0
product-recommendation 156 156 0
recommendation 192.2 192.2 0
ssr 173.5 173.5 0

Copy link
Collaborator

@louis-bompart louis-bompart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look nice!
Wondering how we should proceed regarding Cypress:

  • use the same version as the other packages but then have another package to update when we do the update batch
  • use the latest version and saves one update, but be out-of-sync with the other package, causing us to install cypress twice

@btaillon-coveo
Copy link
Contributor

Wondering how we should proceed regarding Cypress:

  • use the same version as the other packages but then have another package to update when we do the update batch
  • use the latest version and saves one update, but be out-of-sync with the other package, causing us to install cypress twice

I personally really don't mind either way, I don't think the differences are gonna be that significant.

@mrrajamanickam-coveo mrrajamanickam-coveo merged commit 7ce3945 into master Aug 11, 2023
33 checks passed
@mrrajamanickam-coveo mrrajamanickam-coveo deleted the KIT-2643_e2e_headless_ssr branch August 11, 2023 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants