Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(version): update semver, simplify code #33

Merged
merged 2 commits into from May 25, 2022
Merged

chore(version): update semver, simplify code #33

merged 2 commits into from May 25, 2022

Conversation

louis-bompart
Copy link
Collaborator

  • Updated semver to 7.3.7
  • Simplify the code: now that semver.inc is really pure, it's not modifying the version object given in param anymore. So we can stop passing version.version and just pass version in.

fixes #27

@louis-bompart louis-bompart requested review from a team, GermainBergeron and aiheon and removed request for a team May 20, 2022 14:24
@louis-bompart louis-bompart merged commit bdf23fc into main May 25, 2022
@louis-bompart louis-bompart deleted the chore/#27 branch May 25, 2022 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GermainBergeron GermainBergeron GermainBergeron approved these changes

@aiheon aiheon aiheon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to semver 7.3.7
3 participants
@louis-bompart @GermainBergeron @aiheon