Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SFINT-5504): new methods to expand and collapse generated answer added to search and insight client #456

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

mmitiche
Copy link
Contributor

@mmitiche mmitiche commented Apr 18, 2024

SFINT-5504

new analytics methods added to the search and insight clients:

  • logExpandGeneratedAnswer.
  • logCollapseGeneratedAnswer.

These new events will be logged when the generated answer will expanded and collapsed according to the new feature that will be supported by the RGA component allowing the end user to expand or collapse a generated answer.

@mmitiche mmitiche changed the title feat(AFINT-5504): new method to expand and collapse generated answer added to search and insight client feat(AFINT-5504): new methods to expand and collapse generated answer added to search and insight client Apr 18, 2024
@mmitiche mmitiche marked this pull request as ready for review April 18, 2024 12:01
@mmitiche mmitiche requested review from fvanham-coveo and a team as code owners April 18, 2024 12:01
@mmitiche mmitiche changed the title feat(AFINT-5504): new methods to expand and collapse generated answer added to search and insight client feat(SFINT-5504): new methods to expand and collapse generated answer added to search and insight client Apr 18, 2024
Copy link
Contributor

@jelmedini jelmedini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good !!!

Copy link
Contributor

@erocheleau erocheleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just questions that I have but just to confirm, everything looks good

src/searchPage/searchPageEvents.ts Outdated Show resolved Hide resolved
src/searchPage/searchPageClient.ts Outdated Show resolved Hide resolved
@mmitiche mmitiche merged commit b9ce2d6 into master Apr 19, 2024
5 checks passed
@mmitiche mmitiche deleted the SFINT-5504 branch April 19, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants