Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(packaging): fix deb packaging #57

Merged
merged 7 commits into from Mar 1, 2021
Merged

chore(packaging): fix deb packaging #57

merged 7 commits into from Mar 1, 2021

Conversation

olamothe
Copy link
Member

@olamothe olamothe commented Mar 1, 2021

Use https://www.npmjs.com/package/patch-package (already used for other dependency in the project) to fix missing sudo for deb (linux) packaging with oclif-dev.

https://coveord.atlassian.net/browse/CDX-107

@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2021

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

@olamothe olamothe marked this pull request as ready for review March 1, 2021 16:49
@olamothe olamothe changed the title fix(packaging): fix deb packaging chore(packaging): fix deb packaging Mar 1, 2021
@louis-bompart
Copy link
Collaborator

What was the symptom/problem? (link to a brokey build would be nice)

I ain't found of npm patch either tbh.
(And the more we do this the more I think we should kick oclif-dev if it's ain't working properly without hacking)

@@ -29,7 +33,7 @@ jobs:
run: ${{ matrix.additional-install }}
- name: Create package
working-directory: ./packages/cli
run: npx @oclif/dev-cli pack:${{ matrix.pack-command }}
run: ./node_modules/@oclif/dev-cli/bin/run pack:${{ matrix.pack-command }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you tried sudo this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's not the problem.

@olamothe
Copy link
Member Author

olamothe commented Mar 1, 2021

What was the symptom/problem? (link to a brokey build would be nice)

Example: https://github.com/coveo/cli/runs/2005635079?check_suite_focus=true

I ain't found of npm patch either tbh.
(And the more we do this the more I think we should kick oclif-dev if it's ain't working properly without hacking)

So, following the discussion during the scrum here is the accompanying issue on oclif-dev repo:

oclif/dev-cli#244

@louis-bompart
Copy link
Collaborator

patch === oclif/dev-cli#282

@olamothe olamothe merged commit 8598daa into master Mar 1, 2021
@olamothe olamothe deleted the CDX-107 branch March 1, 2021 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants