build(deps) npm update + shadow-bump of commitizen #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louis-bompart
changed the title
|
Pull Request Report PR Title ❌ Title should follow the conventional commit spec: (optional scope): Example: feat(cli): add new command |
louis-bompart
commented
May 13, 2021
Comment on lines
+27
to
+29
| ({ | ||
| getAllOrgsUserHasAccessTo: mockGetOrgs, | ||
| } as unknown) as AuthenticatedClient) | ||
| } as unknown as AuthenticatedClient) |
There was a problem hiding this comment.
prettier has spoken.
louis-bompart
commented
May 13, 2021
| @@ -11,7 +11,7 @@ describe('hooks:prerun', () => { | |||
| const mockSet = jest.fn(); | |||
|
|
|||
| mockConfig.mockImplementation( | |||
| () => (({get: mockGet, set: mockSet} as unknown) as Config) | |||
| () => ({get: mockGet, set: mockSet} as unknown as Config) | |||
There was a problem hiding this comment.
prettier has spoken.
louis-bompart
commented
May 13, 2021
Comment on lines
+19
to
+28
| ({ | ||
| set: mockSet, | ||
| } as unknown) as Config) | ||
| } as unknown as Config) | ||
| ); | ||
|
|
||
| mockedClient.mockImplementation( | ||
| () => | ||
| (({ | ||
| ({ | ||
| getUserHasAccessToOrg: mockGetHasAccessToOrg, | ||
| } as unknown) as AuthenticatedClient) | ||
| } as unknown as AuthenticatedClient) |
There was a problem hiding this comment.
prettier has spoken.
louis-bompart
commented
May 13, 2021
Comment on lines
+16
to
+19
| ({ | ||
| get: mockGet, | ||
| set: mockSet, | ||
| } as unknown) as Config) | ||
| } as unknown as Config) |
There was a problem hiding this comment.
prettier has spoken.
louis-bompart
commented
May 13, 2021
Comment on lines
+55
to
+58
| ({ | ||
| get: mockConfigGet, | ||
| set: mockConfigSet, | ||
| } as unknown) as Config) | ||
| } as unknown as Config) |
There was a problem hiding this comment.
prettier has spoken.
louis-bompart
commented
May 13, 2021
Comment on lines
+38
to
+41
| ({ | ||
| getAllOrgsUserHasAccessTo: mockListOrgs, | ||
| getUserHasAccessToOrg: mockGetHasAccessToOrg, | ||
| } as unknown) as AuthenticatedClient) | ||
| } as unknown as AuthenticatedClient) |
There was a problem hiding this comment.
prettier has spoken.
louis-bompart
force-pushed
the
CDX-227-commitizen
branch
from
779ef45
to
e9b8fc3
Compare
olamothe
approved these changes
May 13, 2021
y-lakhdar
approved these changes
May 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://github.com/coveo/cli/security/dependabot/package-lock.json/merge/open
Diagnostic:
Resolution: commitizen/cz-cli#824
On our end, we just 'update' the sub dep (it's janky: install the dep version you want, then uninstall it. The pkg-lock tho will keep the version you installed).
This makes so we have our dependency tree updated and don't have to wait for
cz-conventional-changelogto be bumped.Also, bonus round: I ran an
npm updateto dust off our deps.Edit: Bonus round 2. Updated to prettier 2.3.0
https://prettier.io/blog/2021/05/09/2.3.0.html
Some minor changes, reapplied prettier to the project to keep it tidy
CDX-227