simplify naming #925

faddat · 2023-05-07T20:51:48Z

Description

Binary names and paths were too long.

This PR:

interchain-security-cd => consumer
interchain-security-cdd => democracy
interchain-security-pd => provider

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

confirmed the correct type prefix in the PR title
confirmed ! in the type prefix if API or client breaking change
confirmed all author checklist items have been addressed
reviewed state machine logic
reviewed API design and naming
reviewed documentation is accurate
reviewed tests and test coverage

jtremback · 2023-05-09T20:17:16Z

This just changes the binary names? I like the idea

faddat · 2023-05-09T20:19:13Z

yep. I just need to clean it up and such, should be able to get to it tomorrow.

It is inspired by typing:

interchain-security-pd

too many times

:)

jtremback · 2023-05-11T15:34:05Z

I'm getting test failures on this even after re-running. Can you check that the e2e tests all have the updated binary names?

faddat · 2023-05-11T19:16:23Z

ah that's why it is still on draft.

interchain-security-pd => provider

faddat · 2023-05-13T23:00:06Z

hmmmm I thought i had this working....

faddat · 2023-05-13T23:02:24Z

@jtremback please note that we could debug this directly on github, if we changed the automated tests to use the --verbose flag as seen in #867

that would:

prioritize human time over machine time
make agreeing on the state of bugs easier
reduce overall time spent to diagnose and fix issues

... idk exactly how things work at Informal but at Notional we've noticed very consistently that machines are dramatically cheaper than the people who program them.

faddat · 2023-05-13T23:18:13Z

For reference, 5/5 vietnamese undersea cables have some kind of fault right now.

Thus, i am still downloading docker containers.

jtremback · 2023-05-22T22:02:12Z

LGTM but looks like some merge conflicts snuck in

shaspitz · 2023-06-09T21:50:32Z

Set this to draft, but once the merge conflicts are fixed I'm happy to review

shaspitz

Not sure that changing "democracy consumer" to "democracy" is beneficial or makes things clearer.

Making binary names shorter is fine (that's what this PR was originally intended to do).

Aside: There's plenty of open issues which describe refactors that the core team would find to be useful, see https://github.com/cosmos/interchain-security/issues?q=is%3Aopen+is%3Aissue+label%3Arefactoring

README.md

app/democracy/app.go

docs/docs/features/key-assignment.md

Co-authored-by: Shawn <44221603+smarshall-spitzbart@users.noreply.github.com>

faddat · 2023-07-06T16:54:20Z

Not sure that changing "democracy consumer" to "democracy" is beneficial or makes things clearer.

yeah the idea was def to make binary names shorter, any other name changes, were done for the sake of consistency is there a specific instance where this is an issue?

Happy to address

faddat · 2023-07-06T16:56:08Z

https://github.com/cosmos/interchain-security/issues?q=is%3Aopen+is%3Aissue+label%3Arefactoring

🖖

thank you

restore d's

faddat · 2023-07-06T17:00:37Z

testutil/ibc_testing/specific_setup.go

@@ -14,7 +14,7 @@ import (
 	"github.com/cometbft/cometbft/libs/log"

 	appConsumer "github.com/cosmos/interchain-security/v3/app/consumer"
-	appConsumerDemocracy "github.com/cosmos/interchain-security/v3/app/consumer-democracy"
+	appConsumerDemocracy "github.com/cosmos/interchain-security/v3/app/democracy"


was this what you were unsure of @smarshall-spitzbart ?

jtremback · 2023-07-17T21:24:30Z

Merge conflicts snuck in again, can merge once it's fixed though

faddat · 2023-08-13T12:35:06Z

@jtremback hey sorry about the delay here. Baby gap sir.

…labs/interchain-security into short-name-less-typing

faddat · 2023-08-20T17:58:13Z

I've merged main, hopefully this fixes the cometmocktest.

mpoke

LGTM. Just one nit below.

mpoke · 2023-09-19T08:40:35Z

docs/docs/features/key-assignment.md

@@ -63,7 +63,7 @@ OR
 gaiad query provider validator-provider-key <consumer-chain-id> consumervalcons1e....123asdnoaisdao
 ```

-You must use a `valcons` address. You can obtain it by querying your node on the consumer `consumerd tendermint show-address`
+You must use a `valcons` address. You can obtain it by querying your node on the consumer `consumer tendermint show-address`


This should be consumerd.

mpoke · 2023-09-19T08:53:38Z

@faddat Could you please also add the compiler/linker flags (ldflags) during the build call so that we can also close #1035? We decided against goreleaser for ICS, but it would be useful to populate those fields for the version CLI command.

mpoke · 2023-09-20T07:46:56Z

Dockerfile

+COPY --from=is-builder /go/bin/providerd /usr/local/bin/providerd
+COPY --from=is-builder /go/bin/consumerd /usr/local/bin/consumerd
+COPY --from=is-builder /go/bin/democracyd /usr/local/bin/democracyd
+COPY --from=is-builder /go/bin/sovereignd /usr/local/bin/sovereignd


Could you also change sovereign to standalone? Calling a non-ICS chain sovereign, entails that consumer chains don't have sovereignty, which is not true.

yeah I'm good with this change sir

simplify naming

2e3c17f

faddat requested a review from a team as a code owner May 7, 2023 20:51

faddat marked this pull request as draft May 7, 2023 20:52

more simplification

a065680

Merge branch 'main' into short-name-less-typing

6c23de4

Merge branch 'main' into short-name-less-typing

ee13d11

faddat added 2 commits May 12, 2023 02:22

complete the renaming

e63fdad

consumer-democracy => democracy, interchain-security-cd => consumer

d33a660

interchain-security-pd => provider

faddat marked this pull request as ready for review May 11, 2023 19:28

faddat added 2 commits May 12, 2023 02:29

little more renaming

264b151

lint markdown

4ce51ff

faddat added 2 commits May 14, 2023 06:22

update Makefile

ea2df13

rename consumerdemocracy => democracy

c16d0ce

faddat marked this pull request as draft May 13, 2023 23:27

faddat added 3 commits May 14, 2023 06:28

complete renaming consumerdemocracy

e8cf68a

naming

e54ce99

naming

eb59920

faddat mentioned this pull request May 13, 2023

Make the CI system work on the 47 upgrade branch #956

Closed

faddat marked this pull request as ready for review May 13, 2023 23:36

iprovider -> provider

da12dad

shaspitz marked this pull request as draft June 9, 2023 21:50

faddat marked this pull request as ready for review July 3, 2023 10:13

shaspitz reviewed Jul 3, 2023

View reviewed changes

README.md Outdated Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

app/democracy/app.go Outdated Show resolved Hide resolved

docs/docs/features/key-assignment.md Outdated Show resolved Hide resolved

faddat and others added 5 commits July 7, 2023 00:43

Merge remote-tracking branch 'origin/main' into short-name-less-typing

4ff94d0

Update README.md

6a9b0f3

Co-authored-by: Shawn <44221603+smarshall-spitzbart@users.noreply.github.com>

Update README.md

4751d0b

Co-authored-by: Shawn <44221603+smarshall-spitzbart@users.noreply.github.com>

Update app/democracy/app.go

a322178

Co-authored-by: Shawn <44221603+smarshall-spitzbart@users.noreply.github.com>

Merge branch 'main' into short-name-less-typing

3de445f

Update key-assignment.md

492f4bf

restore d's

faddat commented Jul 6, 2023

View reviewed changes

faddat added 3 commits August 13, 2023 20:35

Merge branch 'short-name-less-typing' of https://github.com/notional-…

0a26b28

…labs/interchain-security into short-name-less-typing

Merge remote-tracking branch 'origin/main' into short-name-less-typing

14b95bc

Merge remote-tracking branch 'origin/main' into short-name-less-typing

c84191a

github-actions bot added C:Testing Assigned automatically by the PR labeler C:Build Assigned automatically by the PR labeler C:Docs Assigned automatically by the PR labeler labels Aug 20, 2023

faddat added 2 commits September 16, 2023 11:46

Merge remote-tracking branch 'origin/main' into short-name-less-typing

59471df

fix naming issues

b1a20b9

github-actions bot added the C:x/provider Assigned automatically by the PR labeler label Sep 16, 2023

mpoke approved these changes Sep 19, 2023

View reviewed changes

mpoke reviewed Sep 20, 2023

View reviewed changes

faddat added 2 commits January 1, 2024 17:35

Merge remote-tracking branch 'origin/main' into short-name-less-typing

b378536

complete merge

838fb50

github-actions bot added the C:x/consumer Assigned automatically by the PR labeler label Jan 1, 2024

mpoke self-requested a review January 4, 2024 10:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

simplify naming #925

simplify naming #925

faddat commented May 7, 2023 •

edited

jtremback commented May 9, 2023

faddat commented May 9, 2023

jtremback commented May 11, 2023

faddat commented May 11, 2023

faddat commented May 13, 2023

faddat commented May 13, 2023 •

edited

faddat commented May 13, 2023

jtremback commented May 22, 2023

shaspitz commented Jun 9, 2023

shaspitz left a comment

faddat commented Jul 6, 2023

faddat commented Jul 6, 2023

faddat Jul 6, 2023

jtremback commented Jul 17, 2023

faddat commented Aug 13, 2023

faddat commented Aug 20, 2023

mpoke left a comment

mpoke Sep 19, 2023

mpoke commented Sep 19, 2023

mpoke Sep 20, 2023

faddat Feb 10, 2024

simplify naming #925

Are you sure you want to change the base?

simplify naming #925

Conversation

faddat commented May 7, 2023 • edited

Description

Author Checklist

Reviewers Checklist

jtremback commented May 9, 2023

faddat commented May 9, 2023

jtremback commented May 11, 2023

faddat commented May 11, 2023

faddat commented May 13, 2023

faddat commented May 13, 2023 • edited

faddat commented May 13, 2023

jtremback commented May 22, 2023

shaspitz commented Jun 9, 2023

shaspitz left a comment

Choose a reason for hiding this comment

faddat commented Jul 6, 2023

faddat commented Jul 6, 2023

faddat Jul 6, 2023

Choose a reason for hiding this comment

jtremback commented Jul 17, 2023

faddat commented Aug 13, 2023

faddat commented Aug 20, 2023

mpoke left a comment

Choose a reason for hiding this comment

mpoke Sep 19, 2023

Choose a reason for hiding this comment

mpoke commented Sep 19, 2023

mpoke Sep 20, 2023

Choose a reason for hiding this comment

faddat Feb 10, 2024

Choose a reason for hiding this comment

faddat commented May 7, 2023 •

edited

faddat commented May 13, 2023 •

edited