Upgrade SDK to v0.45.11 #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update IBC-go ref * Please enter the commit message for your changes. Lines starting
sainoe
requested review from
jtremback,
mpoke,
danwt and
shaspitz
as code owners
jtremback
reviewed
Nov 16, 2022
| @@ -48,13 +48,14 @@ func (h Hooks) AfterUnbondingInitiated(ctx sdk.Context, ID uint64) { | |||
|
|
|||
| // Set unbondingOp | |||
| if err := h.k.SetUnbondingOp(ctx, unbondingOp); err != nil { | |||
| panic(fmt.Errorf("unbonding op could not be persisted: %w", err)) | |||
| return fmt.Errorf("unbonding op could not be persisted: %w", err) | |||
There was a problem hiding this comment.
What happens on the other side when this error is returned? It's hard to find out what actual branch you're using from the go mod file.
There was a problem hiding this comment.
There was a problem hiding this comment.
Previously we panicked for this error, and now we do not. Is this change in behavior ok and intentional? Does it even matter?
There was a problem hiding this comment.
@jtremback the SDK branch used is in the description
@smarshall-spitzbart RunTx normally recovers all the panic in tx executions https://docs.cosmos.network/v0.45/core/runtx_middleware.html so I think doesn't change the logic and it's more a matter of logging the error.
There was a problem hiding this comment.
I agree that this should return an error instead of panicking, especially since AfterUnbondingInitiated has error as a return field
There was a problem hiding this comment.
I agree that this should return an error instead of panicking, especially since AfterUnbondingInitiated has error as a return field.
The error return field is introduced in this PR, I'm just pointing out that I think this PR will change behavior. Whether that matters, I'm not sure.
From the link @sainoe has given
Depending on the panic type a different handler is used, for instance the default one prints an error log message.
I agree that we will log an error before and after this PR👍
There is still a change in behavior AFAIK tho. If we panic, execution of the tx will halt and not be committed. Whereas with the new functionality, we log an error and continue tx execution.
To make this PR not change any functionality, we'd need to panic on the sdk side of things
There was a problem hiding this comment.
Yea we need to leave the panics. They roll back the tx
shaspitz
suggested changes
Nov 17, 2022
| github.com/stretchr/testify v1.7.1 | ||
| github.com/spf13/cast v1.5.0 | ||
| github.com/spf13/cobra v1.6.0 | ||
| github.com/stretchr/testify v1.8.0 |
There was a problem hiding this comment.
This is the upgrade that is causing our CI to fail, is there a way to reference the older version of testify?
There was a problem hiding this comment.
We can downgrade them manually in the go.mod replace block. But what's failing exactly?
| @@ -48,13 +48,14 @@ func (h Hooks) AfterUnbondingInitiated(ctx sdk.Context, ID uint64) { | |||
|
|
|||
| // Set unbondingOp | |||
| if err := h.k.SetUnbondingOp(ctx, unbondingOp); err != nil { | |||
| panic(fmt.Errorf("unbonding op could not be persisted: %w", err)) | |||
| return fmt.Errorf("unbonding op could not be persisted: %w", err) | |||
There was a problem hiding this comment.
Previously we panicked for this error, and now we do not. Is this change in behavior ok and intentional? Does it even matter?
shaspitz
approved these changes
Nov 17, 2022
2 tasks
shaspitz
added a commit
that referenced
this pull request
Nov 18, 2022
faddat
pushed a commit
to notional-labs/interchain-security
that referenced
this pull request
Apr 21, 2023
* * Bump SDK to v0.45.11 * Update IBC-go ref * Please enter the commit message for your changes. Lines starting * downgrade testify in go mod Co-authored-by: Jehan <jehan.tremback@gmail.com> Co-authored-by: Shawn Marshall-Spitzbart <44221603+smarshall-spitzbart@users.noreply.github.com>
faddat
added a commit
to notional-labs/interchain-security
that referenced
this pull request
Apr 21, 2023
commit 2d64523e766e51221ea27d95f45b5ea0c1157bc9
Merge: ece7bc92 d346fca3
Author: Jacob Gadikian <jacobgadikian@gmail.com>
Date: Fri Apr 21 16:32:37 2023 +0700
Merge remote-tracking branch 'filter/new_branch_sdk47' into sdk-47-fifth-go-notional
commit ece7bc92a0b388fde32efc39358e3a096949457a
Merge: 8763d99c ead0d214
Author: Jacob Gadikian <jacobgadikian@gmail.com>
Date: Fri Apr 21 16:26:55 2023 +0700
Merge remote-tracking branch 'filter/new_branch_sdk47' into new-new-new-sdk47
commit ead0d21487858fef5e30ddbaf7cedb47b41d7296
Author: Jacob Gadikian <jacobgadikian@gmail.com>
Date: Thu Apr 20 14:22:26 2023 +0700
remove proto files completely
commit 79f565a4d51c08a961e48450be108f6a08ee7a23
Author: Jacob Gadikian <jacobgadikian@gmail.com>
Date: Thu Apr 20 14:16:49 2023 +0700
make protos match exactly
commit c4c856c049c4a718ebf063df279a613d5db56819
Author: Jacob Gadikian <jacobgadikian@gmail.com>
Date: Thu Apr 20 14:14:51 2023 +0700
make protos match the v7.0.x branch exactly
commit af812332d52cb972204490e89e1e3d75bb626141
Author: Jacob Gadikian <jacobgadikian@gmail.com>
Date: Thu Apr 20 14:11:31 2023 +0700
remove even more proto code
commit d346fca39ef2ab0e4af257209fa13ab163dd240d
Author: Jacob Gadikian <jacobgadikian@gmail.com>
Date: Thu Apr 20 13:56:33 2023 +0700
remove unneeded proto deps and build with many fewer
commit 97e7021559eaa10a3a8020df5b930f688c7a3ecd
Author: Jacob Gadikian <jacobgadikian@gmail.com>
Date: Thu Apr 20 13:56:33 2023 +0700
remove unneeded proto deps and build with many fewer
commit 1e8ccaf467260c8830f99c2386e11fc414861e9c
Author: Jacob Gadikian <jacobgadikian@gmail.com>
Date: Thu Apr 20 12:25:46 2023 +0700
update proto build image
commit ddb6218eccad467013b7c585a70bac2eb039d017
Author: Jacob Gadikian <jacobgadikian@gmail.com>
Date: Thu Apr 20 12:25:46 2023 +0700
update proto build image
commit 56b0fbb21ea9a366f158d56a6546c4fef4ec1f54
Author: Jacob Gadikian <jacobgadikian@gmail.com>
Date: Thu Apr 20 11:53:55 2023 +0700
ics23
commit 90b85107b2ca1e7ffff48ec32b11800b7bd9f258
Author: Jacob Gadikian <jacobgadikian@gmail.com>
Date: Thu Apr 20 10:52:30 2023 +0700
bump ics23 and cosmos/gogoproto
commit 19fc8a0da6ddd86bb295d413e8ae4928b33f4f0c
Author: Ruslan Akhtariev <rakhtariev@icloud.com>
Date: Thu Apr 20 11:35:55 2023 +0800
Revert "remove code from third party -> add deps directly to buf.yml"
This reverts commit a53d890f831a20060da57877f19ec769d6a506f6.
commit a53d890f831a20060da57877f19ec769d6a506f6
Author: Ruslan Akhtariev <rakhtariev@icloud.com>
Date: Thu Apr 20 11:34:07 2023 +0800
remove code from third party -> add deps directly to buf.yml
commit 009754a6dd8bca13d58803b9ea05353e84c69294
Merge: 5510632e 8e2ce98b
Author: Jacob Gadikian <jacobgadikian@gmail.com>
Date: Thu Apr 20 10:26:38 2023 +0700
Merge remote-tracking branch 'origin/main' into new_branch_sdk47
commit 8e2ce98b1f26f3af38a4920831afea671279b005
Author: Shawn <44221603+smarshall-spitzbart@users.noreply.github.com>
Date: Wed Apr 19 11:23:21 2023 -0700
bump: ibc 4.3 (#862)
ibc 4.3
commit 60f30315f8801141de7c1df04fa2339b0322ad96
Author: Jacob Gadikian <jacobgadikian@gmail.com>
Date: Wed Apr 19 23:54:46 2023 +0800
chore: use go 1.20 (#840)
* rm GenPubKey
* use go 1.19 since go 1.18 is no longer supported
* update go version in Dockerfiles and github actions
* remove ioutil because it's deprecated
* gofumpt
* pass linter
* use go 1.20
* change the version of go mentioned in other files
* quote the version of go in in the linter action
* ignore deprecation of rand.Seed for testing
* protocgen.sh
* Update README.md
---------
Co-authored-by: Shawn <44221603+smarshall-spitzbart@users.noreply.github.com>
Co-authored-by: Marius Poke <marius.poke@posteo.de>
commit 88d79f88b8724754ca4a4a6a21f41a6c2d370d51
Merge: b672630b d0ee1ee6
Author: Jacob Gadikian <jacobgadikian@gmail.com>
Date: Wed Apr 19 23:13:10 2023 +0800
Merge branch 'main' into new_branch_sdk47
commit d0ee1ee66b2eb69c039402f5d3e34a2e2a01a51a
Author: Thomas Bruyelle <thomasbruyelle@hey.com>
Date: Wed Apr 19 16:55:22 2023 +0200
fix(build): make proto-update-deps (#830)
* fix(build): make proto-update-deps
The URL to the cosmos-sdk SDK_PROTO_URL was using a branch that doesn't
exists (any more I presume). As a result, `make proto-update-deps`
wasn't working properly and was filling all the cosmos proto files with
`404 Not Found`.
Fix by using the correct branch name, which is
`interchain-security-rebase.0.45.11`.
* use SDK latest tag
commit 5510632e3a380c4ef79919dd4551f439176a7530
Author: Ruslan Akhtariev <rakhtariev@icloud.com>
Date: Tue Apr 18 15:18:49 2023 +0800
tidy: goleveldb pin
commit 36cf4d4d07deccf835fc4219283fdc506320e7fd
Author: Ruslan Akhtariev <rakhtariev@icloud.com>
Date: Tue Apr 18 15:18:26 2023 +0800
pin goleveldb
commit 87df25f5538b87ff43c91f3a10362689f675fcbc
Author: Ruslan Akhtariev <rakhtariev@icloud.com>
Date: Tue Apr 18 15:05:44 2023 +0800
go mod tidy
commit 8e0a395584ea3455fa6406e4ee7469dc62b68d25
Author: Jacob Gadikian <jacobgadikian@gmail.com>
Date: Tue Apr 18 01:33:29 2023 +0700
don't remplace testify
commit d6adf6d94b5f94afc2476e63b2b77ca8d1b44bb7
Merge: e3ccae4c c663d072
Author: Jacob Gadikian <jacobgadikian@gmail.com>
Date: Tue Apr 18 01:16:39 2023 +0700
Merge remote-tracking branch 'origin/main' into new_branch_sdk47
commit c663d072616cf90bbd3aed79a8e0e153636731ca
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date: Mon Apr 17 10:47:24 2023 -0700
Bump github.com/spf13/cobra from 1.6.1 to 1.7.0 (#855)
Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.6.1 to 1.7.0.
- [Release notes](https://github.com/spf13/cobra/releases)
- [Commits](https://github.com/spf13/cobra/compare/v1.6.1...v1.7.0)
---
updated-dependencies:
- dependency-name: github.com/spf13/cobra
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
commit c16364c166db5870a5cff700d45e14afcafffa8a
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date: Mon Apr 17 10:23:26 2023 -0700
Bump github.com/stretchr/testify from 1.8.1 to 1.8.2 (#854)
Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.8.1 to 1.8.2.
- [Release notes](https://github.com/stretchr/testify/releases)
- [Commits](https://github.com/stretchr/testify/compare/v1.8.1...v1.8.2)
---
updated-dependencies:
- dependency-name: github.com/stretchr/testify
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
commit e3ccae4cd7b5daa89937e5c21d7771de5f6f94d0
Author: Jacob Gadikian <jacobgadikian@gmail.com>
Date: Mon Apr 17 23:08:25 2023 +0700
reinstate the forked sdk because it is needed for success
commit b672630bada19249db7bd759c0af771cae5697b8
Merge: 7ca44282 f7fb129e
Author: Jacob Gadikian <jacobgadikian@gmail.com>
Date: Mon Apr 17 21:36:20 2023 +0700
Merge remote-tracking branch 'origin/main' into new_branch_sdk47
commit 9143c7403cfd2b948522023ed11fc16b6b641a39
Merge: 2cc7cbc1 6fce17db
Author: Jacob Gadikian <jacobgadikian@gmail.com>
Date: Mon Apr 17 21:36:20 2023 +0700
Merge remote-tracking branch 'origin/main' into new_branch_sdk47
commit 2cc7cbc1156ba33caaf81e06bc007fdd1c6eea3d
Author: Jacob Gadikian <jacobgadikian@gmail.com>
Date: Mon Apr 17 20:45:41 2023 +0700
use the errors module
commit 55e9f828c374d5d482b93eacec40659c6fb330b4
Author: vuong177 <nguyenvuong1122000@gmail.com>
Date: Mon Apr 17 13:46:08 2023 +0800
minor
commit 80efa87ecc74131c061c9f181d8a30c4db1f0b5b
Author: vuong177 <nguyenvuong1122000@gmail.com>
Date: Mon Apr 17 12:49:50 2023 +0800
using Son's ibc go version
commit 064a58831c4c821d0a06425e2202e76882f8c441
Author: vuong <nguyenvuong1122000@gmail.com>
Date: Fri Apr 14 19:17:07 2023 +0700
bypass valset check when init genesis
commit 7ca44282579d579874a6d9ea504e3184e63f1b96
Merge: 1909670e 5a94f896
Author: vuong <56973102+vuong177@users.noreply.github.com>
Date: Fri Apr 14 16:17:35 2023 +0700
Merge pull request #1 from notional-labs/vuong/fix-proto
fix gogo proto
commit 941a1320e56d0684a054c3910418adbfe8ea301d
Merge: 17f12f08 f61acf37
Author: vuong <56973102+vuong177@users.noreply.github.com>
Date: Fri Apr 14 16:17:35 2023 +0700
Merge pull request #1 from notional-labs/vuong/fix-proto
fix gogo proto
commit 5a94f896bbd909e75f32b83c084e355d276b1bdb
Author: vuong <nguyenvuong1122000@gmail.com>
Date: Fri Apr 14 16:14:41 2023 +0700
fix gogo proto
commit f61acf37a7676ec155a22e74d38432aa654a52b7
Author: vuong <nguyenvuong1122000@gmail.com>
Date: Fri Apr 14 16:14:41 2023 +0700
fix gogo proto
commit f7fb129e9db991a6ab714ad6689221e84c7b894b
Author: Shawn <44221603+smarshall-spitzbart@users.noreply.github.com>
Date: Thu Apr 13 06:58:33 2023 -0700
Soft opt out (#833)
* WIP soft opt out code with incomplete boilerplate
* proto changes
* Seems like it should work
* Unit test for UpdateLargestSoftOptOutValidatorPower
* fixes and renames, unit tests work
* update comment
* log
* Update proto/interchain_security/ccv/consumer/v1/consumer.proto
Co-authored-by: Marius Poke <marius.poke@posteo.de>
* better validation for soft opt out threshhold
* improve test
* slicestable
* semantics and improved test
* use correct key util
* Update module.go
* comment
* updated semantics
* separate files
* fix TestMakeConsumerGenesis test
* fix naming
* change upper bound on soft opt out thresh
* fix test
* allow empty valset for tests
* gofumpt and fix from merge
* Update x/ccv/consumer/types/params_test.go
* Update x/ccv/consumer/types/params.go
* Soft opt out diff tests (#847)
* wip
* fixes for ts build
* AI fixed my bug lol
* throw error when needed
* comment
* disable soft opt-out in diff testing
* update diff testing model
* update UTs
---------
Co-authored-by: mpoke <marius.poke@posteo.de>
* add comment about beginblocker order requirement for soft opt-out
---------
Co-authored-by: Jehan Tremback <hi@jehan.email>
Co-authored-by: Marius Poke <marius.poke@posteo.de>
Co-authored-by: Simon Noetzlin <simon.ntz@gmail.com>
commit 6fce17dbf96fa973601eb7949c2178dafc763109
Author: Jacob Gadikian <jacobgadikian@gmail.com>
Date: Thu Apr 13 19:46:29 2023 +0700
bump: sdk v0.45.15-ics (#805)
* use 45.15
* ibc-go 4.3.0
* fix copylocks lints
* remove the change to ibc-go
* fix lint
* illustrate flaky test
* more revert
* run linter
* make config.yml match origin/main
* Revert "make tests match origin/main"
This reverts commit 37db99170f627fcc4489f3108f2e055281eb2c01, reversing
changes made to 16060078f2d4ae2526e136946c9da155769469ff.
---------
Co-authored-by: Jehan <jehan.tremback@gmail.com>
Co-authored-by: lg <8335464+glnro@users.noreply.github.com>
Co-authored-by: Marius Poke <marius.poke@posteo.de>
commit 673b6c44af8fd0eddbc90c7c3db05fc25cc8ae85
Author: Shawn <44221603+smarshall-spitzbart@users.noreply.github.com>
Date: Wed Apr 12 03:24:41 2023 -0700
Fix Makefile (#837)
Update Makefile
Co-authored-by: Simon Noetzlin <simon.ntz@gmail.com>
commit cf1ef3cea805cbde93a8f11435ba5cc1928b2650
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date: Tue Apr 11 11:56:38 2023 +0200
Bump github.com/spf13/cobra from 1.6.1 to 1.7.0 (#834)
Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.6.1 to 1.7.0.
- [Release notes](https://github.com/spf13/cobra/releases)
- [Commits](https://github.com/spf13/cobra/compare/v1.6.1...v1.7.0)
---
updated-dependencies:
- dependency-name: github.com/spf13/cobra
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
commit 722b4eca5ffb27ad990496edf3c3f39dc8c7ab9f
Author: Jacob Gadikian <jacobgadikian@gmail.com>
Date: Tue Apr 11 01:56:32 2023 +0700
use ibc v4.3.0 (#823)
* use ibc v4.3.0
* ensure we always cite the correct version of ics
* go mod tidy
commit 17f12f08fa8b16b67fd80a05094eefb46c511500
Author: sontrinh16 <trinhleson2000@gmail.com>
Date: Thu Apr 6 14:01:54 2023 +0700
add crisis store key
Signed-off-by: sontrinh16 <trinhleson2000@gmail.com>
commit 79dc25df468a6c682725d7322950e81a12ef20c5
Author: sontrinh16 <trinhleson2000@gmail.com>
Date: Wed Apr 5 20:42:08 2023 +0700
fix conflict with main
commit 1909670e298a3d2dc94da45d6ec296e57fdca4de
Merge: c76c7284 7fd358f4
Author: sontrinh16 <trinhleson2000@gmail.com>
Date: Wed Apr 5 15:48:00 2023 +0700
fix bug
commit 487c8a083b43d4a5d8a64a78ae4cd62e884b722d
Merge: 4e68ecef b27ab1c3
Author: sontrinh16 <trinhleson2000@gmail.com>
Date: Wed Apr 5 15:48:00 2023 +0700
fix bug
commit b27ab1c3d20dac0e6c57faac85ed805e72fa4f1c
Author: Jacob Gadikian <jacobgadikian@gmail.com>
Date: Wed Apr 5 14:16:41 2023 +0700
Remove spm (#812)
* successful spm removal
* add app params
* fix codec/marshaler
commit 7fd358f47df7c1ebef4548ed2bb507c33671a81f
Author: Shawn <44221603+smarshall-spitzbart@users.noreply.github.com>
Date: Tue Apr 4 20:43:46 2023 -0700
feat: standalone to consumer changeover part 1 (#757)
* on-chain upgrade to consumer chain wip
* add preCCV store and use it on democracy staking
* add TODOs and one more packet possibility
* status update
* Resolve hermes start issue for trusted validator set by changing revision height
* remove intermediary logs
* remove further unused codebase
* updates for endblocker test, existing test fixes, get last validators
* update for slashing sovereign validators for the fault made before consumer chain upgrade height
* resolve comments on github and slack communication
* update sovereign app to use v4 ibc from v3 & resolve consumer module merge conflict fix issue
* Update app/sovereign/upgrades/v3/upgrades.go
Co-authored-by: yaruwangway <69694322+yaruwangway@users.noreply.github.com>
* rm sovereign chain and tests. Will be replaced by simapp and integration tests
* duplicate module name
* add comment
* small rename
* remove democracy staking changes
* consumer ccv beginblock, endblock, and initgenesis order shouldn't matter
* add mock calls to compile
* adjust tests for new keeper field
* add registerDemocConsumer method
* split out preCCV flag and initial valset
* cleanup consumer module
* cleanup
* more cleanup
* temp changes to validators.go
* comment out test
* rm bad code from merge
* comment
* Update app.go
* UTs for CRUD
* UTs for keys
* use make for mocks
* todo
* changeover method and test
* resolve #783
* comment
* comments
* add appropriate TODOs, restore changes to main
* final nits before non-draft
* comment on ChangeoverToConsumer
* more clear comment
* small comment change
* update InitGenesis comment
* sovereign -> standalone
* missed a file
* builds now
* update comment after debug
* naming refactor
* edge case for val in old and new sets
* restore keys after rebase
---------
Co-authored-by: jstr1121 <jun@stridelabs.co>
Co-authored-by: jstr1121 <118450565+jstr1121@users.noreply.github.com>
Co-authored-by: yaruwangway <69694322+yaruwangway@users.noreply.github.com>
commit c76c7284804f7a56f5a240c68c43fcb1c6db6d6b
Merge: b9db2396 46f568f5
Author: sontrinh16 <trinhleson2000@gmail.com>
Date: Wed Apr 5 10:30:54 2023 +0700
fixing merge conflict
commit 46f568f57de69b3462c167e898a770399c68c891
Author: Simon Noetzlin <simon.ntz@gmail.com>
Date: Tue Apr 4 14:12:45 2023 +0200
chore: swap name of 'e2e' and 'integration' tests (#681)
* save first changes
* fix gh workflow
* update gh actions
* fix bug
* squash commits
* Simply use Test rather than Ingt for naming integration test keepers
* update git workflows
commit 4e68eceff1e76335fbb30835b3142fc14d79a145
Author: Son Trinh <sontrinh@Sons-MacBook-Pro.local>
Date: Sun Apr 2 08:54:04 2023 +0700
fix register interface
commit f695d048869819fc7053fc9182864b2270578bbe
Author: Son Trinh <sontrinh@Sons-MacBook-Pro.local>
Date: Fri Mar 31 16:49:33 2023 +0700
try ibc v7 testing
commit b9db2396b53235873072a26484e654ebfe2e9afa
Author: Son Trinh <sontrinh@Sons-MacBook-Pro.local>
Date: Thu Mar 30 17:06:37 2023 +0700
fix x folder
commit 1ade668399bf678319bd1fe2b8519b89af569b03
Author: Son Trinh <sontrinh@Sons-MacBook-Pro.local>
Date: Wed Mar 29 17:14:43 2023 +0700
add forked staking proto
commit b4103d3644db155df36653a873ddf3d06512efde
Author: Son Trinh <sontrinh@Sons-MacBook-Pro.local>
Date: Wed Mar 29 17:14:43 2023 +0700
add forked staking proto
commit 539b4891444c4d63e18cbe98255f32d39263a6c1
Author: Son Trinh <sontrinh@Sons-MacBook-Pro.local>
Date: Wed Mar 29 13:32:07 2023 +0700
fixing err
commit 881513b7015e3ae538740c80e569a22d214e1e8a
Author: Jacob Gadikian <jacobgadikian@gmail.com>
Date: Fri Mar 24 05:24:39 2023 +0700
lint code including the conversion away from the ignite cli
commit fc7ce65ae25cacbccff6924124808c011f6adc5f
Merge: 4a1b356a 658feb12
Author: Jacob Gadikian <jacobgadikian@gmail.com>
Date: Fri Mar 24 05:21:33 2023 +0700
lint code including the conversion away from the ignite cli
commit d8c696e45b6b7522665b55b4e05e9981126300b9
Author: Shawn <44221603+smarshall-spitzbart@users.noreply.github.com>
Date: Thu Mar 23 11:35:58 2023 -0700
Introduce docs website (#759)
* init docusaurus repo
* unify theme with cosmos-sdk docs
* update config
* add FAQ sections
* terms
* Create overview.md
* consumer dev folder
* smol
* Create technical-specification.md
* add new stuff
* add key assignment documentation
* fix typo
* add clarification
* update documentation; add features section; improve overview
* mv website to docs root; mv old readmes to old_docs
* add doc deployer
* make deployable to github pages
* add consumer initiated slashing doc page
* sovereign -> standalone
* add validators section
* fix typos
* update small things
* rename validator stuff
* add joining-testnet docs
* add title to joining testnet
* minor refactors
* refactor faq, update testnet guide
* update footers
* update testnet repo links
* Fix typo
Change ". Ie." to ", i.e."
* Fix typo: you key => your key
* Fix typo: cosumer => consumer
* update copyright section so docusaurus builds
* Add . at the end of info boxes
* Minor grammar change
* Add missing word "the"
* Fix typo
* update broken link for ics-testnets
* Remove duplicated paragraphs
* Adjust wording
---------
Co-authored-by: Matija Salopek <matija.salopek994@gmail.com>
Co-authored-by: MSalopek <35486649+MSalopek@users.noreply.github.com>
Co-authored-by: Philip Offtermatt <57488781+p-offtermatt@users.noreply.github.com>
commit 4a1b356a24d2f19b00cd671de8c4c295a2bd9c9e
Author: Jacob Gadikian <jacobgadikian@gmail.com>
Date: Fri Mar 24 01:35:16 2023 +0700
format code
commit 658feb121a0dc9c2310ee64d8f69b82cad05728a
Author: Jacob Gadikian <jacobgadikian@gmail.com>
Date: Fri Mar 24 01:19:24 2023 +0700
remove ignite
commit cf6217b9a3b2acf102cfe502d0b2e91630312553
Author: Jacob Gadikian <jacobgadikian@gmail.com>
Date: Fri Mar 24 00:36:29 2023 +0700
use 45.15
commit 8bf3c80feb4f91d7e2b9b3e3ef7c1ac709e41901
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date: Mon Mar 20 14:24:08 2023 -0700
Bump google.golang.org/protobuf from 1.28.2-0.20220831092852-f930b1dc76e8 to 1.30.0 (#793)
Bump google.golang.org/protobuf
Bumps google.golang.org/protobuf from 1.28.2-0.20220831092852-f930b1dc76e8 to 1.30.0.
---
updated-dependencies:
- dependency-name: google.golang.org/protobuf
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Shawn <44221603+smarshall-spitzbart@users.noreply.github.com>
commit 0f7ba20ec157afc8c0af2b974f08fdc000837c0c
Author: Thomas Bruyelle <thomasbruyelle@hey.com>
Date: Thu Mar 16 08:13:24 2023 +0100
chore: add Makefile target to generate mocks (#769)
commit 449979799eedf23d0cfefe55f7797f06db5db35f
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date: Tue Mar 14 11:37:53 2023 -0700
Bump github.com/golang/protobuf from 1.5.2 to 1.5.3 (#779)
Bumps [github.com/golang/protobuf](https://github.com/golang/protobuf) from 1.5.2 to 1.5.3.
- [Release notes](https://github.com/golang/protobuf/releases)
- [Commits](https://github.com/golang/protobuf/compare/v1.5.2...v1.5.3)
---
updated-dependencies:
- dependency-name: github.com/golang/protobuf
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Shawn <44221603+smarshall-spitzbart@users.noreply.github.com>
commit b85fb0f31f43822c50e939b98bbe18a0b854f000
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date: Tue Mar 14 11:20:10 2023 -0700
Bump github.com/tidwall/gjson from 1.14.0 to 1.14.4 (#776)
Bumps [github.com/tidwall/gjson](https://github.com/tidwall/gjson) from 1.14.0 to 1.14.4.
- [Release notes](https://github.com/tidwall/gjson/releases)
- [Commits](https://github.com/tidwall/gjson/compare/v1.14.0...v1.14.4)
---
updated-dependencies:
- dependency-name: github.com/tidwall/gjson
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Shawn <44221603+smarshall-spitzbart@users.noreply.github.com>
commit 97b65fc1296c84647c385a9e309780c24df3b6c2
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date: Tue Mar 14 17:33:26 2023 +0100
Bump golang.org/x/net from 0.5.0 to 0.7.0 (#763)
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.5.0 to 0.7.0.
- [Release notes](https://github.com/golang/net/releases)
- [Commits](https://github.com/golang/net/compare/v0.5.0...v0.7.0)
---
updated-dependencies:
- dependency-name: golang.org/x/net
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Marius Poke <marius.poke@posteo.de>
commit 85235c8b0efabfce98c98bf5628bac46b9c8b7a4
Author: MSalopek <35486649+MSalopek@users.noreply.github.com>
Date: Mon Mar 6 18:53:41 2023 +0100
allow using gaia as provider in integration tests (#735)
* allow using gaia as provider in integration tests
* add changes to makefile
* add gaia dockerfile
* update testing docs
* update Makefile; validate gaia tags (support >= v9.x.x)
---------
Co-authored-by: Shawn <44221603+smarshall-spitzbart@users.noreply.github.com>
commit cf02d4f45b0c935e890acfd1a7a1efc5869a033a
Author: Shawn <44221603+smarshall-spitzbart@users.noreply.github.com>
Date: Thu Mar 2 13:48:08 2023 -0800
Key assignment type safety (#725)
* pb changes
* nvm dont wanna open that can of worms
* still wip
* more fixes
* almost
* builds
* helpers and fixed one file
* comments
* mas
* test fix
* fix another
* types
* smol
* un mas
* un mas
* nit
* reformat
* mas
* fix last bug
* to fix integration test
* proper way to do stringer
* Update slashing.go
* Update slashing.go
* links
* comments
* Update keeper.go
* smol
* nit
* changes to TestHandleEquivocationProposal
* merge with fixes
* merge fix
* comment
---------
Co-authored-by: MSalopek <35486649+MSalopek@users.noreply.github.com>
commit 7f2207ad77b6faf568e8ff4b9d1d372d33b09692
Author: MSalopek <35486649+MSalopek@users.noreply.github.com>
Date: Thu Mar 2 17:52:59 2023 +0100
update protos; fix missing proto dependencies (#752)
commit 7ee9fcd763d712bede87748ada7b41590f731c10
Author: MSalopek <35486649+MSalopek@users.noreply.github.com>
Date: Tue Feb 28 18:03:17 2023 +0100
add interchain security consumer QueryParams (#746)
add QueryParams
commit 5932ba2af8febf131472b16286ad61162ec4259e
Author: Simon Noetzlin <simon.ntz@gmail.com>
Date: Thu Feb 9 15:32:47 2023 +0100
bump SDK version to v0.45.13-ics (#727)
* bump sdk
* Update tm to 34.26
* Bump sdk and tm version fix
---------
Co-authored-by: lg <8335464+glnro@users.noreply.github.com>
Co-authored-by: lg <lauren@informal.systems>
commit 78e46265aa974e2af01125cd0f68894becdc6e08
Author: MSalopek <35486649+MSalopek@users.noreply.github.com>
Date: Mon Feb 6 19:53:53 2023 +0100
remove liquidity, feegrant and authz keepers (#700)
Co-authored-by: Simon Noetzlin <simon.ntz@gmail.com>
Co-authored-by: Shawn <44221603+smarshall-spitzbart@users.noreply.github.com>
commit 0ddbd12b762d1120bb8fa1432edc10ed5de88689
Author: Thomas Bruyelle <thomas.bruyelle@gmail.com>
Date: Mon Feb 6 18:17:31 2023 +0100
feat: Equivocation gov proposal (#703)
This change adds a new kind of gov proposal that will slash and
tombstone validators for double-signing.
The proposal handler is added in the `provider` module, and use the
`evidence` module to handle the equivocations.
Co-authored-by: Albert Le Batteux <contact@albttx.tech>
Co-authored-by: Jehan <jehan.tremback@gmail.com>
commit 535e8e07e0e1cfabc0ff697be22e4ab55afcd66b
Author: Simon Noetzlin <simon.ntz@gmail.com>
Date: Mon Feb 6 16:52:01 2023 +0100
bump SDK version (#709)
bump sdk
commit 0724edce7de9327dc57f50b95bc64738714824bf
Author: Shawn <44221603+smarshall-spitzbart@users.noreply.github.com>
Date: Mon Jan 30 10:16:30 2023 -0800
fix: slash meter replenishment (#687)
* this test should fail
* changes
* refactors
* smol
* comments
* naming
* smalls
* update E2e tests to validate new behavior
* nit
* whoops
* change key name
* set time w/in method
* fix typo
commit 7f8a21d90ac699be1f3425a51ad5bc2851543df6
Author: Shawn <44221603+smarshall-spitzbart@users.noreply.github.com>
Date: Fri Jan 20 05:01:36 2023 -0800
Bump IBC refs to ver 4.2.0 (#654)
* Update gitignore
* Add ibc testing folder
* WIP replacing ibcsim
* Tests pass
* Update ibc-go dependency
* Remove TODOs
* Remove unused code
* Fixes ibcsim simapp dep
* Remove unneeded simapp code from #632 (#636)
delete code
* Fix lint
* Update dependencies and linters
* Test gosec ignore
* Fix gosec
* Fix linting
* Update sonarcloud ignore for ibc
* Revert lint change
* Removed unused code
* Refactor ibc directory
* Add back gaia tests and add ibc-testing disclosure
* wip
* compiles
* tests pass
* todos
* fix codeql file indentation
* 2nd attempt to fix codeql
* 3rd attempt
* update OnChanOpenInit version handling to follow ics26
* revert module version
* remove version checking in provider OnChanOpenInit
* address left TODOs
Co-authored-by: lg <lauren@interchain.io>
Co-authored-by: Daniel <danwtisdall@gmail.com>
Co-authored-by: lg <8335464+glnro@users.noreply.github.com>
Co-authored-by: Simon Noetzlin <simon.ntz@gmail.com>
Co-authored-by: Marius Poke <marius.poke@posteo.de>
commit ac4be76bf07788ae5aae6fc40907aac51b531926
Author: Shawn <44221603+smarshall-spitzbart@users.noreply.github.com>
Date: Fri Jan 20 05:01:36 2023 -0800
Bump IBC refs to ver 4.2.0 (#654)
* Update gitignore
* Add ibc testing folder
* WIP replacing ibcsim
* Tests pass
* Update ibc-go dependency
* Remove TODOs
* Remove unused code
* Fixes ibcsim simapp dep
* Remove unneeded simapp code from #632 (#636)
delete code
* Fix lint
* Update dependencies and linters
* Test gosec ignore
* Fix gosec
* Fix linting
* Update sonarcloud ignore for ibc
* Revert lint change
* Removed unused code
* Refactor ibc directory
* Add back gaia tests and add ibc-testing disclosure
* wip
* compiles
* tests pass
* todos
* fix codeql file indentation
* 2nd attempt to fix codeql
* 3rd attempt
* update OnChanOpenInit version handling to follow ics26
* revert module version
* remove version checking in provider OnChanOpenInit
* address left TODOs
Co-authored-by: lg <lauren@interchain.io>
Co-authored-by: Daniel <danwtisdall@gmail.com>
Co-authored-by: lg <8335464+glnro@users.noreply.github.com>
Co-authored-by: Simon Noetzlin <simon.ntz@gmail.com>
Co-authored-by: Marius Poke <marius.poke@posteo.de>
commit 2e064193dd1e0aeea2149548818d23dc849ed189
Author: MSalopek <35486649+MSalopek@users.noreply.github.com>
Date: Fri Jan 20 12:09:51 2023 +0100
run happy path tests on push; bump hermes version (#659)
* use official hermes release
* refactor integration test main.go
* update automated-tests integration test run
* fix worng container teardown
* refactor main.go; add parallel execution
* update Makefile
* simplify code
* refactor for naming consistency
* fix string formatting
commit 42f1d1f8cde56c0d7769f88ed5a7a2f3344de0e9
Author: lg <8335464+glnro@users.noreply.github.com>
Date: Wed Jan 18 15:30:07 2023 +0100
Remove Gaia Provider Test (#669)
* Remove gaia from instance test and move to its own repo
* Remove gaia from dependencies
commit 951a394c7da41fd64b7d4476877a2a9a664e0219
Author: Shawn <44221603+smarshall-spitzbart@users.noreply.github.com>
Date: Wed Jan 11 09:10:44 2023 -0800
Removes depreciated keyring dependency (#657)
changes
commit 74f2437503188b741f432d3ddb2e245943332c99
Author: lg <8335464+glnro@users.noreply.github.com>
Date: Tue Jan 10 16:34:28 2023 +0100
Update IBC-Go to canonical v3.4.0 (#632)
* Update gitignore
* Add ibc testing folder
* WIP replacing ibcsim
* Tests pass
* Update ibc-go dependency
* Remove TODOs
* Remove unused code
* Fixes ibcsim simapp dep
* Remove unneeded simapp code from #632 (#636)
delete code
* Fix lint
* Update dependencies and linters
* Test gosec ignore
* Fix gosec
* Fix linting
* Update sonarcloud ignore for ibc
* Revert lint change
* Removed unused code
* Refactor ibc directory
* Add back gaia tests and add ibc-testing disclosure
* Add README
Co-authored-by: Daniel <danwtisdall@gmail.com>
Co-authored-by: Shawn <44221603+smarshall-spitzbart@users.noreply.github.com>
commit 7c9d0934002377f2b95d7d722fe0101df5f190fc
Author: Marius Poke <marius.poke@posteo.de>
Date: Fri Dec 23 18:44:10 2022 +0100
Fix: Iteration through PacketMaturityTimes assumes maturity time order (#622)
* WIP convert iterators to array getters.
Still need to rename functions, and some compile errors in tests.
* WIP - compiles, fixing tests
* Unit and e2e tests work
* add notes about stopping iteration
* WIP - rename and add some notes
* Add types to proto
* delete unused code
* resolve naming conflict
* implement another type as proto
* fixing more stuff
* delete TODOJEHAN.md
* adds many of Marius's iteration order comments from 599, and does some small refactors for clarity
* fix nil pointer deref
* call GetAllConsumerChains once
* expand TestGetAllChannelToChains
* expand TestGetAllUnbondingOps
* GetAllUnbondingOpIndexes; cleanup proto files
* fix GetAllValsetUpdateBlockHeights and UTs
* remove GetAllSlashAck
* add tests for GetFirstVscSendTimestamp
* key assignment iterators
* reviewed proposals
* add TestGetAllValsetUpdateBlockHeights
* add TestGetAllOutstandingDowntimes
* add GetElapsedPacketMaturityTimes
* fix linter
* fix linter
* prevent implicit memory aliasing
* add UTC to TestPacketMaturityTime
* fix TestPacketMaturityTime
* avoid local variable name shadowing
* Update x/ccv/consumer/keeper/keeper.go
Co-authored-by: Shawn <44221603+smarshall-spitzbart@users.noreply.github.com>
* replace cases with packets in TestPacketMaturityTime
* add expected order to TestPacketMaturityTime
* add expected order to TestGetAllHeightToValsetUpdateIDs
* add expected order to TestGetAllOutstandingDowntimes
* add TestGetAllCCValidator
* add expected order to TestGetAllConsumerChains
* add expected order to TestGetAllChannelToChains
* add expected order to TestGetAllUnbondingOps
* add expected order to TestGetAllUnbondingOpIndexes
* add expected order to TestGetAllValsetUpdateBlockHeights
* add expected order to TestInitTimeoutTimestamp
* add expected order to TestVscSendTimestamp
* add expected order to TestGetAllValidatorConsumerPubKey
* add expected order to TestGetAllValidatorsByConsumerAddr
* add expected order to TestGetAllKeyAssignmentReplacements
* add expected order to TestGetAllConsumerAddrsToPrune
* iterate over packet maturities in order of time
* fix linter
* move AppendMany to utils
* review suggestions
* refactor TestPacketMaturityTime UT
* nits
Co-authored-by: Jehan Tremback <hi@jehan.email>
Co-authored-by: Shawn <44221603+smarshall-spitzbart@users.noreply.github.com>
commit 4063734e3584a93175159ef1e09843360fae3335
Author: Simon Noetzlin <simon.ntz@gmail.com>
Date: Thu Dec 22 17:43:04 2022 +0100
refactor: wrap VSCMatured/Slash packets into a consumer packet type (#626)
* refactor: create a consumer packet type
- Create a ConsumerPacketData type definition at the CCV protocol level
- Update consumer to send ConsumerPacketData to provider
- Update provider to receive ConsumerPacketData
Co-authored-by: mpoke <marius.poke@posteo.de>
commit e8bc5b878efef22b5dde5df4977abda5645d3322
Author: Jehan <jehan.tremback@gmail.com>
Date: Wed Dec 21 15:18:02 2022 -0800
Refactor: Convert iterators to array getters (#596)
* WIP convert iterators to array getters.
Still need to rename functions, and some compile errors in tests.
* WIP - compiles, fixing tests
* Unit and e2e tests work
* add notes about stopping iteration
* WIP - rename and add some notes
* Add types to proto
* delete unused code
* resolve naming conflict
* implement another type as proto
* fixing more stuff
* delete TODOJEHAN.md
* adds many of Marius's iteration order comments from 599, and does some small refactors for clarity
* fix nil pointer deref
* call GetAllConsumerChains once
* expand TestGetAllChannelToChains
* expand TestGetAllUnbondingOps
* GetAllUnbondingOpIndexes; cleanup proto files
* fix GetAllValsetUpdateBlockHeights and UTs
* remove GetAllSlashAck
* add tests for GetFirstVscSendTimestamp
* key assignment iterators
* reviewed proposals
* add TestGetAllValsetUpdateBlockHeights
* add TestGetAllOutstandingDowntimes
* add GetElapsedPacketMaturityTimes
* fix linter
* fix linter
* prevent implicit memory aliasing
* add UTC to TestPacketMaturityTime
* fix TestPacketMaturityTime
* avoid local variable name shadowing
* Update x/ccv/consumer/keeper/keeper.go
Co-authored-by: Shawn <44221603+smarshall-spitzbart@users.noreply.github.com>
* replace cases with packets in TestPacketMaturityTime
* add expected order to TestPacketMaturityTime
* add expected order to TestGetAllHeightToValsetUpdateIDs
* add expected order to TestGetAllOutstandingDowntimes
* add TestGetAllCCValidator
* add expected order to TestGetAllConsumerChains
* add expected order to TestGetAllChannelToChains
* add expected order to TestGetAllUnbondingOps
* add expected order to TestGetAllUnbondingOpIndexes
* add expected order to TestGetAllValsetUpdateBlockHeights
* add expected order to TestInitTimeoutTimestamp
* add expected order to TestVscSendTimestamp
* add expected order to TestGetAllValidatorConsumerPubKey
* add expected order to TestGetAllValidatorsByConsumerAddr
* add expected order to TestGetAllKeyAssignmentReplacements
* add expected order to TestGetAllConsumerAddrsToPrune
* Add test for GetSlashAndTrailingData (#623)
* add test
* comments
* Update throttle.go
* use InitTimeoutTimestamp instead of two slices
* Fix: Change keys for storing proposals (#620)
* change keys for storing proposals
* apply review suggestions
* Apply suggestions from code review
Co-authored-by: Shawn <44221603+smarshall-spitzbart@users.noreply.github.com>
Co-authored-by: Jehan <jehan.tremback@gmail.com>
Co-authored-by: Shawn <44221603+smarshall-spitzbart@users.noreply.github.com>
Co-authored-by: mpoke <marius.poke@posteo.de>
Co-authored-by: Shawn <44221603+smarshall-spitzbart@users.noreply.github.com>
commit 8603f9c97548fb4f3979e85e99bb6979b0eaf269
Author: MSalopek <35486649+MSalopek@users.noreply.github.com>
Date: Tue Dec 20 20:29:32 2022 +0100
add slash throttling queries (#600)
* add slash throttle queries
* add slash throttle integration tests
* add integration tests
* add integration tests
* make tests pass
* should build now
* implicit memory aliasing stuff
* rm file
* refactor queries
* changes
* new wrapper type
* Throttle queries refactors (#614)
* refactors
* Update state.go
* rm duplicated imports
* change slash meter params in default test run
* add comment
* move state checks to provider
Co-authored-by: Shawn Marshall-Spitzbart <44221603+smarshall-spitzbart@users.noreply.github.com>
commit 0657172ad63490f62ddbb22f7518e0b223cd9844
Author: Shawn <44221603+smarshall-spitzbart@users.noreply.github.com>
Date: Tue Dec 20 06:11:53 2022 -0800
GlobalSlashEntry protobuf type (#613)
* changes
* indentation fix
* un mas
commit 43249d53bb0102dc438d5685181a0f434cd4771e
Author: Shawn <44221603+smarshall-spitzbart@users.noreply.github.com>
Date: Mon Dec 19 10:37:17 2022 -0800
Throttle refactors (#611)
* comments and move panic
* proto changes
* naming
* remove break label
* refactor HandlePacketDataForChain
* Revert "refactor HandlePacketDataForChain"
This reverts commit 8f6a29679e1499d605579e941ed74ba67b1d4e05.
* comment
* comments
commit 61608316cf01d1388907e18290c7f2c894c2c0fa
Author: Shawn <44221603+smarshall-spitzbart@users.noreply.github.com>
Date: Mon Dec 19 10:37:17 2022 -0800
Throttle refactors (#611)
* comments and move panic
* proto changes
* naming
* remove break label
* refactor HandlePacketDataForChain
* Revert "refactor HandlePacketDataForChain"
This reverts commit 8f6a29679e1499d605579e941ed74ba67b1d4e05.
* comment
* comments
commit a6716a6a6e6e00992a0f2b05b985edf98b76bad9
Author: lg <8335464+glnro@users.noreply.github.com>
Date: Fri Dec 16 16:52:09 2022 +0100
refactor: TrustingPeriodFraction should be a fraction. (#593)
* WIP
* Refactor TrustingPeriodFraction
* Update default TrustingPeriodFraction to 2/3 or 66%
Co-authored-by: Jehan <jehan.tremback@gmail.com>
commit a7c79fa40207cf8dc3ce5295e328097b7a532741
Author: lg <8335464+glnro@users.noreply.github.com>
Date: Tue Dec 13 20:14:41 2022 +0100
chore: Update gaia dependency for e2e provider test (#578)
Update Gaia dependency for e2e provider test
Co-authored-by: Shawn Marshall-Spitzbart <44221603+smarshall-spitzbart@users.noreply.github.com>
commit 3a8d0a27dfdb2abece8ce5dd86ae5172e8652581
Author: MSalopek <35486649+MSalopek@users.noreply.github.com>
Date: Thu Dec 8 09:57:42 2022 +0100
update consumer addition proposal (#558)
* update ConsumerAdditionProposal in provider.proto
* add ValidateBasic for ConsumerAdditionProposal message
* fix failing ValidateBasic tests
* make all tests work
* make all tests work
* update proposal in integration tests
* update comment
* refactor after rebase
* run make proto-gen after rebase on main
* remove LockUnbonding flag and references from repo (PR #551)
* refactor after reviews
commit f57c604c2e2a51c1e9dafad1d9e0332e461e2bf4
Author: Marius Poke <marius.poke@posteo.de>
Date: Wed Dec 7 11:52:49 2022 +0100
Key assignment (#515)
* add MsgAssignConsumerKey
* add MsgAssignConsumerKey
* fix package name
* add keys
* add keeper methods for key assignment
* handle MsgAssignConsumerKey
* map addresses in slash requests
* prune old consumer addresses
* move AssignConsumerKey logic to keeper
* update consumer initial valset
* add ApplyKeyAssignmentToValUpdates
* fix client creation
* do not check init valset on consumer
* clean state on val removal
* fix TestAssignConsensusKeyForConsumerChain
* delete on val removal
* remove reverse mapping on val removal
* remove pending key assignment in EndBlock
* add query endpoints
add summary of indexes
change ConsumerValidatorByVscID to ConsumerAddrsToPrune
* Refactor AssignConsumerKey for clarity (IMO)
* finish key assignment genesis code- untested
* FIxed mocks compile issue - not sure if it works right though.
* add test for init and export genesis
* set after get in AssignConsumerKey
* enable AssignConsumerKey to be called twice
* remove key assignment on chain removal
* apply some review comments
* fix bug: two validator with same consumer key
* rename key: ConsumerValidatorsByVscIDBytePrefix -> ConsumerAddrsToPruneBytePrefix
* PendingKeyAssignment -> KeyAssignmentReplacements
* msg.ProviderAddr is a validator addr
* fix: key assignment genesis tests (#517)
* Fix consumer init genesis test
* fix provider genesis tests
* fix key assignement handler
* fix linter
* fix merge conflict
* fix ProviderValidatorAddress
* remove unused expectation
Co-authored-by: Marius Poke <marius.poke@posteo.de>
* add key assignment CRUD operations unit tests (#516)
* test val consumer key related CRUD
* test val consumer addr related CRUD
* test pending key assignments related CRUD
* refactor after review session
* refactor after review session
* add prune key CRUD tests
* renamings in testfiles
* improve KeyAssignmentReplacement set and get
* remove ApplyKeyAssignmentToInitialValset (redundant)
* add invariant to docstring of AppendConsumerAddrsToPrune
* fix address conversion
* adding e2e tests
* fix linter
* add queries; setup integration tests (#519)
* add queries; setup integration testse
* test key assignment before chain start
* fix state queries; refactor
* rm extra comment
* rm unused action field
* bump voting times in all tests
* add provider address query to tests
* Adds some very basic random testing and unit tests (#522)
* Adds imports
* Does multi iterations: fails!
* Handle errs
* checkpoint debug
* Pre introduce dynamic mock
* Issue seems to be resolved
* Removes prints in key asisgn
* Removes debug, pre reintroduce all test features
* Fix some magic numbers, bring back prune check
* Pre rework initial assignments
* Refactor and tidyup
* Better docs, clarity, org
Co-authored-by: Daniel <danwtisdall@gmail.com>
* Enable key assignment testing for all e2e tests (#524)
* split CCVTestSuite.setupCallback in two
* pre-assign keys for all vals of first consumer
* fix linter
* remove TestConsumerGenesis
* adding ADR
* move handler.go outside client/
* replace [][]byte with AddressList
* remove IterateAllConsumerAddrsToPrune; not needed
* apply review suggestions
* fix linter
* Danwt/key assignment slash test (#545)
* cp
* wip
* note
* cp
* Adds slash test
Co-authored-by: Daniel <danwtisdall@gmail.com>
* Fixes #503 prevents two key assignment key overlap security issues (#556)
* Deletes out of date duplicate code
* Adds check that validator with key does not already exist
* Partially adjust assign unit test
* Finishes adjusting unit
* Updates stress test to never find a validator
* Improves comment
* Fixes handler_test
* Adds validatorI iterator to expected keeper
* Implements AfterValidatorCreated hook
* Names
* Simplifies validator query
* Adds hooks test
* Remove TODO
* Fix random sim test
Co-authored-by: Daniel <danwtisdall@gmail.com>
* Bump AssignConsumerKey comment
* improve comments for iterators
* Masa/key assignment integration tests amend (#548)
* handle gosec false positive
* add err checks for key assign; rm multiconsumer tests
* guestimate block window for keyswaps in happyPeth
* start multiconsumer with flag
* remove node_modules
* fix comment
Co-authored-by: Jehan Tremback <hi@jehan.email>
Co-authored-by: Simon Noetzlin <simon.ntz@gmail.com>
Co-authored-by: MSalopek <35486649+MSalopek@users.noreply.github.com>
Co-authored-by: Daniel T <30197399+danwt@users.noreply.github.com>
Co-authored-by: Daniel <danwtisdall@gmail.com>
Co-authored-by: Jehan <jehan.tremback@gmail.com>
commit 15321cfa250f12800d541b3be11cc92dc7d5b2e1
Author: lg <8335464+glnro@users.noreply.github.com>
Date: Wed Dec 7 11:29:31 2022 +0100
test: Add CCV Test Suite with Gaia provider (#559)
* fix: delete provider outgoing fees address from blocked address
* Add gaia provider e2e test
* Fix comments
Co-authored-by: Marius Poke <marius.poke@posteo.de>
* Fix comments
Co-authored-by: Marius Poke <marius.poke@posteo.de>
* Update testutil/ibc_testing/specific_setup.go
Co-authored-by: Shawn Marshall-Spitzbart <44221603+smarshall-spitzbart@users.noreply.github.com>
Co-authored-by: Simon Noetzlin <simon.ntz@gmail.com>
Co-authored-by: Marius Poke <marius.poke@posteo.de>
Co-authored-by: Shawn Marshall-Spitzbart <44221603+smarshall-spitzbart@users.noreply.github.com>
commit 174f4cd5965b28fc7cb34fc1f4841857d71a8a18
Author: MSalopek <35486649+MSalopek@users.noreply.github.com>
Date: Mon Dec 5 09:27:28 2022 +0100
refactor provider pending packets handling (#552)
commit fb63b1849862b7d28541065a3636f48bb59555d7
Author: Simon Noetzlin <simon.ntz@gmail.com>
Date: Thu Dec 1 22:05:17 2022 +0100
update provider genesis validation (#525)
* update provider genesis validation
* Update client ID validation for provider genesis
* Make provider VSCID to be stricly positive
Update provider genesis validation
* update comment
* remove tmp files
* fix provider genesis validation bugs
* remove wrongly introduced ibc-go dep
* typo
* improve coverage
Co-authored-by: Shawn Marshall-Spitzbart <44221603+smarshall-spitzbart@users.noreply.github.com>
commit b1a3e53ef301606be0dd09f231fd362c9cee92a9
Author: MSalopek <35486649+MSalopek@users.noreply.github.com>
Date: Tue Nov 22 19:49:19 2022 +0100
add consumer addition proposal documentation (#502)
* add consumer addition proposal documentation
* update after reviews
Co-authored-by: Shawn Marshall-Spitzbart <44221603+smarshall-spitzbart@users.noreply.github.com>
commit 4887d8b81bad1cf9126d846091f349f1ca000e07
Author: Shawn Marshall-Spitzbart <44221603+smarshall-spitzbart@users.noreply.github.com>
Date: Tue Nov 22 04:16:09 2022 -0800
Improve how sent packets are stored in e2e tests (#504)
changes
commit 2466b26406258501f7d9b7c955a81d7248a84944
Author: Simon Noetzlin <simon.ntz@gmail.com>
Date: Fri Nov 18 19:15:43 2022 +0100
Update #264 - updates genesis and genesis tests (#382)
* reformat consumer genesis test
* remove validator fill in of ExportAppStateAndValidators
* checkpoint, testing export genesis consumer
* test consumer export
* make pass the tests
* fix export height to valset update id in consumer
* pass the tests
* pass the tests
* * Update the provider and consumer export/init genesis with the new CCV states
* Improve consumer export genesis UT when channel is established or not
* Set the consumer ExportAppStateAndValidators to not return validators
* Add the new CCV states to the provider and consumer gensis proto files
* remove pendingVSCPackets
* remove references in create consumer chain proposal setters and getters
* fix unchecked errors
* fix iterator bug
* fix linter
* format provider genesis tests
* format consumer genesis tests
* clarify consumer keeper genesis
* remove unused test helpers
* Feat: update consumer init and export genesis
* Stop exporting client and consensus states in consumer genesis
* Add LastTransmissionBlockHeight to genesis proto
* Revert "Feat: update consumer init and export genesis"
This reverts commit eb59e502aa4c8adb35435ff006a7db0fdb5f14c0.
* * Add LastTransmissionBlockHeight to consumer genesis proto
* Set slashing states and LastTransmissionBlockHeight during consumer init genesis
* Update consumer init
* Update consumer genesis export
* fix last nits
* Fix consumer InitGenesis
* Update comments in genesis.proto
* format consumer genesis test
* update comments
* Update provider genesis comments
* fix small lint errs
* * Update consumer genesis validation
* Fix export genesis bug
* Document consumer genesis validation
* Document consumer genesis validation
* Update after #448 merge
* Update x/ccv/consumer/types/genesis.go
Co-authored-by: Marius Poke <marius.poke@posteo.de>
Co-authored-by: Jehan <jehan.tremback@gmail.com>
Co-authored-by: Shawn Marshall-Spitzbart <44221603+smarshall-spitzbart@users.noreply.github.com>
Co-authored-by: Marius Poke <marius.poke@posteo.de>
commit 3362a1ccc44b62339be1c101da22ef14a485ba0c
Author: Marius Poke <marius.poke@posteo.de>
Date: Fri Nov 18 09:45:29 2022 +0100
handle provider and consumer client expiration (#448)
* handle expired client when sending packets
* add e2e test
* add upgradeExpiredClient to e2e tests
* improve incrementTime... functions
* fix golangci-lint error
* add client expired check
* replace incrementTimeBy w/ incrementTime
* replace AppendPendingVSC w/ AppendPendingVSCs
* simplify logic of sendValidatorUpdates
* separate PrepareIBCPacketSend from SendIBCPacket
* error handling on SendPacket
* export pending VSC packets
* improve comments
* use k.GetCCVTimeoutPeriod
* remove GetUpgradeKeeper
* AppendPendingVSCs: use variadic function
* remove unnecessary if
* refactor pending VSC CRUD methods
* refactor sending valset updates to chains
* add tests for VSC queueing
* refactor after reviews
* refactor after reviews
* Merge marius/435-client-expired-consumer into marius/435-client-expired
Squashed commit of the following:
commit 3d82d19304a49938bfef573c99d2a77182167645
Author: mpoke <marius.poke@posteo.de>
Date: Fri Nov 11 10:37:06 2022 +0100
fix typo
commit 1efa9909162acb22a0e6d70e8da540ba437a3a59
Author: mpoke <marius.poke@posteo.de>
Date: Wed Nov 9 19:07:30 2022 +0100
avoid trying to send on expired client
commit a0cb6452776cdf68bf1f35ec5c069bdd76086991
Author: mpoke <marius.poke@posteo.de>
Date: Wed Nov 9 15:56:59 2022 +0100
error handling on SendPacket
commit 7c9c7629966a7d0b894fde3be9ad83f36afac97f
Author: mpoke <marius.poke@posteo.de>
Date: Wed Nov 9 13:55:05 2022 +0100
use PrepareIBCPacketSend pattern on consumer
commit e7ff9d96fd325f851c1c1eb7dc1ed87c65274878
Author: mpoke <marius.poke@posteo.de>
Date: Wed Nov 9 10:17:18 2022 +0100
update QA plan
commit d7fafe8e9987f3b449e3cff07733f8316c484027
Author: mpoke <marius.poke@posteo.de>
Date: Wed Nov 9 10:09:41 2022 +0100
add e2e test TestConsumerPacketSendExpiredClient
commit 1722f1319edb44e3dd867329c6c6875436d9457e
Author: mpoke <marius.poke@posteo.de>
Date: Tue Nov 8 20:20:13 2022 +0100
remove SlashRequest from proto
commit 241e13b2d9d47b641a9054973f4d109c78e68ec6
Author: mpoke <marius.poke@posteo.de>
Date: Tue Nov 8 20:17:52 2022 +0100
remove pending slash requests from genesis
commit 073f10160dd9a1d4cd857043e4dcff494230e489
Author: mpoke <marius.poke@posteo.de>
Date: Tue Nov 8 19:44:46 2022 +0100
replace pending SlashRequests w/ peding DataPackets
commit a2d1069459f99de0c3d2ce8d4794e51cff5cd8ed
Author: mpoke <marius.poke@posteo.de>
Date: Tue Nov 8 19:08:33 2022 +0100
code for pending data packets
commit acc3454279052237054abab26bf20c7f5a42c386
Author: mpoke <marius.poke@posteo.de>
Date: Mon Nov 7 21:03:03 2022 +0100
add e2e test
commit 6170fa879745bb8f1e12f82b47deee13462f3c0e
Author: mpoke <marius.poke@posteo.de>
Date: Mon Nov 7 11:37:57 2022 +0100
handle expired client when sending packets
* and packet queueing to consumer keeper
* refactor e2e tests
* refactor after review session
* additional refactor after reviews
Co-authored-by: Matija Salopek <matija.salopek994@gmail.com>
Co-authored-by: Jehan <jehan.tremback@gmail.com>
commit 05ce55989c73430b3681c5224a34f70447555b7e
Author: Simon Noetzlin <simon.ntz@gmail.com>
Date: Thu Nov 17 22:25:23 2022 +0100
Upgrade SDK to v0.45.11 (#485)
* * Bump SDK to v0.45.11
* Update IBC-go ref
* Please enter the commit message for your changes. Lines starting
* downgrade testify in go mod
Co-authored-by: Jehan <jehan.tremback@gmail.com>
Co-authored-by: Shawn Marshall-Spitzbart <44221603+smarshall-spitzbart@users.noreply.github.com>
commit 34c28bcd3f00afd6c2f0c7b4096abf4169accbec
Author: Shawn Marshall-Spitzbart <44221603+smarshall-spitzbart@users.noreply.github.com>
Date: Mon Nov 14 16:32:31 2022 -0800
circuit breaker params (#444)
* changes
* Update params.go
commit b0840486632e85dffc18420d53a720619949e09f
Author: Marius Poke <marius.poke@posteo.de>
Date: Fri Nov 4 21:49:06 2022 +0100
VSCPackets should have timeout on provider (#422)
* add provider-based timeout params
* add InitTimeoutTimestamp to store
* add init timeout logic
* params boilerplate code & making tests pass
* add TestInitTimeout* e2e tests
* improve e2e tests; add test case to TestUndelegationDuringInit
* remove VSC timeout
* remove VSC timeout param
* add testcase to TestValidateParams
* handle StopConsumerChain error & gofmt
* add VSC timeout period param
* Fix init timeout conflicts (#409)
* Importable e2e tests (#401)
* fixes
* add comment to GetInitTimeoutTimestamp
* add VscTimeoutTimestamp key and tests
* change VSCTimeoutTimestamp key
* fix e2e tests
* add e2e test
* remove useless code
* improve comment
* copy -> append in provider key definitions (#426)
Update keys.go
* Update tests/e2e/unbonding.go
Co-authored-by: Shawn Marshall-Spitzbart <44221603+smarshall-spitzbart@users.noreply.github.com>
* Update x/ccv/provider/keeper/keeper_test.go
Co-authored-by: Shawn Marshall-Spitzbart <44221603+smarshall-spitzbart@users.noreply.github.com>
* update comment
* replace removedChainIds w/ chainIdsToRemove
* changing keys from (chainID, ts) to (chainID, vscID)
* make UnbondingOpIndexKey consistent with VscSendingTimestampKey
Co-authored-by: Shawn Marshall-Spitzbart <44221603+smarshall-spitzbart@users.noreply.github.com>
commit b0089dfb6d030da71beadee2a56852e90d746424
Author: Simon Noetzlin <simon.ntz@gmail.com>
Date: Fri Nov 4 21:03:51 2022 +0100
Bump SDK to v0.45.6 fork (#432)
bump sdk to v0.45.6 with IS changes
commit 46d5c056aa2affe2683dae389274afc4e81fdbf8
Author: Marius Poke <marius.poke@posteo.de>
Date: Tue Nov 1 20:39:30 2022 +0100
Channel initialization timeout (#406)
* add provider-based timeout params
* add InitTimeoutTimestamp to store
* add init timeout logic
* params boilerplate code & making tests pass
* add TestInitTimeout* e2e tests
* improve e2e tests; add test case to TestUndelegationDuringInit
* remove VSC timeout
* remove VSC timeout param
* add testcase to TestValidateParams
* handle StopConsumerChain error & gofmt
* Fix init timeout conflicts (#409)
* Importable e2e tests (#401)
* fixes
* add comment to GetInitTimeoutTimestamp
* Update proto/interchain_security/ccv/provider/v1/provider.proto
Co-authored-by: Aditya <adityasripal@gmail.com>
* fix formatting in proto file
* add comment to SetConsumerChain
* fix typo
* add comment re. EndBlock order
* change name of testcase in TestUndelegationDuringInit
Co-authored-by: Shawn Marshall-Spitzbart <44221603+smarshall-spitzbart@users.noreply.github.com>
Co-authored-by: Aditya <adityasripal@gmail.com>
commit ad9daf23066bde9ca94ab6b94bf22eeb6458d9f5
Author: Marius Poke <marius.poke@posteo.de>
Date: Tue Nov 1 20:39:30 2022 +0100
Channel initialization timeout (#406)
* add provider-based timeout params
* add InitTimeoutTimestamp to store
* add init timeout logic
* params boilerplate code & making tests pass
* add TestInitTimeout* e2e tests
* improve e2e tests; add test case to TestUndelegationDuringInit
* remove VSC timeout
* remove VSC timeout param
* add testcase to TestValidateParams
* handle StopConsumerChain error & gofmt
* Fix init timeout conflicts (#409)
* Importable e2e tests (#401)
* fixes
* add comment to GetInitTimeoutTimestamp
* Update proto/interchain_security/ccv/provider/v1/provider.proto
Co-authored-by: Aditya <adityasripal@gmail.com>
* fix formatting in proto file
* add comment to SetConsumerChain
* fix typo
* add comment re. EndBlock order
* change name of testcase in TestUndelegationDuringInit
Co-authored-by: Shawn Marshall-Spitzbart <44221603+smarshall-spitzbart@users.noreply.github.com>
Co-authored-by: Aditya <adityasripal@gmail.com>
commit a6b8233c72c17019c187e0b6698a260741bd7416
Author: Shawn Marshall-Spitzbart <44221603+smarshall-spitzbart@users.noreply.github.com>
Date: Fri Oct 28 08:34:26 2022 -0700
Consumer Unbonding As Param (#410)
Co-authored-by: Daniel T <30197399+danwt@users.noreply.github.com>
Co-authored-by: Daniel <danwtisdall@gmail.com>
commit 2046d8fff17840f166bd0a0f49a3fa938022103a
Author: MSalopek <35486649+MSalopek@users.noreply.github.com>
Date: Tue Oct 25 15:55:40 2022 +0200
324 create queries for internal ccv state (#366)
* add query protos
* add ConsumerChains provider query
* wip: add queries for pending proposals and distributions
* wip: add queries for pending proposals and distributions
* add stop, start proposals to queries
* add stop, start proposals queries to cli
* add consumer queries
* add fee distribution tests
* test getting consumer chain add/remove proposals
* register consumer queries
* rm unnecessary iterator checks
* unify naming in query functions
* remove matured proposals
* refactor tests and grpc queries
* add client ID to consumer list query
* run make proto-gen after rebase on main
* fix failing tests; reflect repo changes in testutils
* address review comments and refactor
* refactor query consumer chains
* add missing newline in query.proto
Co-authored-by: Marius Poke <marius.poke@posteo.de>
Co-authored-by: Jehan <jehan.tremback@gmail.com>
commit d7bfd3a03b220618a9b5c82eaa8dc217384f39d8
Author: Shawn Marshall-Spitzbart <44221603+smarshall-spitzbart@users.noreply.github.com>
Date: Thu Oct 20 10:47:27 2022 -0700
Replace hardcoded constants with params (#393)
* changes
* edits
* Update params_test.go
* small
* Update genesis_test.go
* remove "num" from historical entries param
* comment
* use params p1
* use params p2
* use params p3
* p4
* change default transfer timeout period
* Update proposal_test.go
* default historical entries
* is negative
* add test case
* forgot one
* comment
commit 946511f10d71df4a0bd09d28ef993ec7db83c9c0
Author: Shawn Marshall-Spitzbart <44221603+smarshall-spitzbart@users.noreply.github.com>
Date: Mon Oct 10 02:11:38 2022 -0700
Make CCV packet timeout a param (#376)
* large commit
* got ridda stuff
* Update params.go
Co-authored-by: Jehan <jehan.tremback@gmail.com>
Co-authored-by: Daniel T <30197399+danwt@users.noreply.github.com>
commit a8d1ee86ba8a96cc53f9475c30db0e98f699c007
Author: Shawn Marshall-Spitzbart <44221603+smarshall-spitzbart@users.noreply.github.com>
Date: Mon Oct 10 02:11:38 2022 -0700
Make CCV packet timeout a param (#376)
* large commit
* got ridda stuff
* Update params.go
Co-authored-by: Jehan <jehan.tremback@gmail.com>
Co-authored-by: Daniel T <30197399+danwt@users.noreply.github.com>
commit 46a9e1a0a5456617511ed18bf720d86f82ab8c92
Author: Shawn Marshall-Spitzbart <44221603+smarshall-spitzbart@users.noreply.github.com>
Date: Tue Oct 4 15:41:29 2022 -0700
close 339 (#373)
Co-authored-by: Jehan <jehan.tremback@gmail.com>
commit 45d52e962e87239988297fd2cd4377fbf44f7b31
Author: Simon Noetzlin <simon.ntz@gmail.com>
Date: Wed Oct 5 00:09:58 2022 +0200
Update export and init genesis (#264)
* reformat consumer genesis test
* remove validator fill in of ExportAppStateAndValidators
* checkpoint, testing export genesis consumer
* test consumer export
* make pass the tests
* fix export height to valset update id in consumer
* pass the tests
* pass the tests
* * Update the provider and consumer export/init genesis with the new CCV states
* Improve consumer export genesis UT when channel is established or not
* Set the consumer ExportAppStateAndValidators to not return validators
* Add the new CCV states to the provider and consumer gensis proto files
* remove pendingVSCPackets
* remove references in create consumer chain proposal setters and getters
* fix unchecked errors
* fix iterator bug
* fix linter
* format provider genesis tests
* format consumer genesis tests
Co-authored-by: Jehan <jehan.tremback@gmail.com>
commit 115d9ecf6e4a57d5e1965dd9861b8600d59366ec
Author: Shawn Marshall-Spitzbart <44221603+smarshall-spitzbart@users.noreply.github.com>
Date: Sat Oct 1 16:48:46 2022 -0500
Add/improve unit tests against spec (#342)
commit 8ac91e113f156d812e9dca22f74991905372b985
Auth…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade SDK to v0.45.11 (IS-fork branch)
Minor changes to work with the SDK team optimizations on SDK 47