Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump comet to v0.37.6 #1876

Merged
merged 8 commits into from
May 17, 2024
Merged

build(deps): bump comet to v0.37.6 #1876

merged 8 commits into from
May 17, 2024

Conversation

mpoke
Copy link
Contributor

@mpoke mpoke commented May 14, 2024

Description

Closes: NA

Bump CometBFT to https://github.com/cometbft/cometbft/releases/tag/v0.37.6 and Cosmos SDK to https://github.com/cosmos/cosmos-sdk/releases/tag/v0.47.11


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • Confirmed the correct type prefix in the PR title
  • Confirmed all author checklist items have been addressed
  • Confirmed that this PR does not change production code

Summary by CodeRabbit

  • Dependencies
    • Updated CometBFT to v0.37.6 for improved performance and stability.

@mpoke mpoke requested a review from a team as a code owner May 14, 2024 08:00
Copy link
Contributor

coderabbitai bot commented May 14, 2024

Walkthrough

The project has been updated to include the latest versions of key dependencies. CometBFT has been upgraded to v0.37.6, enhancing the project with new features and improvements. Additionally, the cosmos-sdk has been bumped to v0.47.11, ensuring compatibility and taking advantage of the latest enhancements in the SDK.

Changes

Files/Paths Change Summary
.changelog/unreleased/dependencies/1876-bump-comet.md Updated CometBFT to v0.37.6.
.changelog/unreleased/dependencies/1876-bump-sdk.md Bumped cosmos-sdk to v0.47.11.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

@@ -0,0 +1,3 @@
- Bump [CometBFT](https://github.com/cometbft/cometbft) to
[v0.37.6](https://github.com/cometbft/cometbft/releases/tag/v0.37.6).
([\#1876](https://github.com/cosmos/interchain-security/pull/1876))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a newline at the end of the file.

Files should end with a single newline character to adhere to POSIX standards.

@MSalopek
Copy link
Contributor

Don't think this will work. e2e tests fail because something changed in config parsing

@mpoke
Copy link
Contributor Author

mpoke commented May 17, 2024

Don't think this will work. e2e tests fail because something changed in config parsing

@MSalopek We need to make it work as we need CometBFT at least v0.37.5 (https://github.com/cosmos/interchain-security/security/dependabot/42)

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

@@ -0,0 +1,3 @@
- Bump [cosmos-sdk](https://github.com/cosmos/cosmos-sdk) to
[v0.47.11](https://github.com/cosmos/cosmos-sdk/releases/tag/v0.47.11).
([\#1876](https://github.com/cosmos/interchain-security/pull/1876))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ensure the file ends with a newline character.

+ 

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
([\#1876](https://github.com/cosmos/interchain-security/pull/1876))
([\#1876](https://github.com/cosmos/interchain-security/pull/1876))

@insumity insumity enabled auto-merge May 17, 2024 13:23
@insumity insumity added this pull request to the merge queue May 17, 2024
Merged via the queue into main with commit 36a2876 May 17, 2024
17 checks passed
@insumity insumity deleted the marius/bump-comet branch May 17, 2024 13:29
mergify bot pushed a commit that referenced this pull request May 17, 2024
* bump comet to v0.37.6

* add changelog entry

* fix exp deps and pin it to go.mod

* bump comet to 0.37.5 and sdk to 0.47.11 to match

* bump comet back to 0.37.6

* add changelog entry for SDK

---------

Co-authored-by: MSalopek <matija.salopek994@gmail.com>
(cherry picked from commit 36a2876)
mergify bot pushed a commit that referenced this pull request May 17, 2024
* bump comet to v0.37.6

* add changelog entry

* fix exp deps and pin it to go.mod

* bump comet to 0.37.5 and sdk to 0.47.11 to match

* bump comet back to 0.37.6

* add changelog entry for SDK

---------

Co-authored-by: MSalopek <matija.salopek994@gmail.com>
(cherry picked from commit 36a2876)

# Conflicts:
#	go.mod
#	go.sum
insumity pushed a commit that referenced this pull request May 17, 2024
* build(deps): bump comet to v0.37.6 (#1876)

* bump comet to v0.37.6

* add changelog entry

* fix exp deps and pin it to go.mod

* bump comet to 0.37.5 and sdk to 0.47.11 to match

* bump comet back to 0.37.6

* add changelog entry for SDK

---------

Co-authored-by: MSalopek <matija.salopek994@gmail.com>
(cherry picked from commit 36a2876)

* update changelog entries

---------

Co-authored-by: Marius Poke <marius.poke@posteo.de>
MSalopek pushed a commit that referenced this pull request May 17, 2024
* build(deps): bump comet to v0.37.6 (#1876)

* bump comet to v0.37.6

* add changelog entry

* fix exp deps and pin it to go.mod

* bump comet to 0.37.5 and sdk to 0.47.11 to match

* bump comet back to 0.37.6

* add changelog entry for SDK

---------

Co-authored-by: MSalopek <matija.salopek994@gmail.com>
(cherry picked from commit 36a2876)

# Conflicts:
#	go.mod
#	go.sum

* update change entries

---------

Co-authored-by: Marius Poke <marius.poke@posteo.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants