Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: store the minimal power to be in the top N on EndBlock, instead of computing on-the-fly #1840

Draft
wants to merge 5 commits into
base: feat/partial-set-security
Choose a base branch
from

Conversation

p-offtermatt
Copy link
Contributor

@p-offtermatt p-offtermatt commented Apr 30, 2024

Description

Closes: #XXXX

Compute the minimal power in the top N on EndBlock, when we compute it anyways for sending VSCPackets.

This should, at worst, delay the ability to opt out by an epoch
(intuitively, when someone is allowed to opt out not because their own power decreases, but because others powers increase, they would still compare against the old, stored MinPowerInTopN and not be allowed to opt out.
This would be solved after the epoch ends and the MinPowerInTopN is updated, however.)

NOTE: Needs a migration; the MInPowerToOptIn needs to be initialized during the migration


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Added ! to the type prefix if the change is state-machine breaking
  • Confirmed this PR does not introduce changes requiring state migrations, OR migration code has been added to consumer and/or provider modules
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Followed the guidelines for building SDK modules
  • Included the necessary unit and integration tests
  • Added a changelog entry to CHANGELOG.md
  • Included comments for documenting Go code
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed
  • If this PR is library API breaking, bump the go.mod version string of the repo, and follow through on a new major release

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! the type prefix if the change is state-machine breaking
  • confirmed this PR does not introduce changes requiring state migrations, OR confirmed migration code has been added to consumer and/or provider modules
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage

@p-offtermatt p-offtermatt requested a review from a team as a code owner April 30, 2024 13:12
@github-actions github-actions bot added C:Testing Assigned automatically by the PR labeler C:x/consumer Assigned automatically by the PR labeler C:x/provider Assigned automatically by the PR labeler C:x/types Assigned automatically by the PR labeler labels Apr 30, 2024
@p-offtermatt p-offtermatt changed the title Ph/store min power feat!: store the minimal power to be in the top N on EndBlock, instead of computing on-the-fly Apr 30, 2024
@p-offtermatt p-offtermatt changed the base branch from main to feat/partial-set-security April 30, 2024 13:12
@insumity
Copy link
Contributor

Thanks for the change.

I'm not in favor of adding this to PSS. I do not see the benefits (i.e., slightly faster query-ing and opting-out) trumping the slight additional complexity that this PR introduces (i.e., additional state and potentially opting-out delays).

@p-offtermatt
Copy link
Contributor Author

Yeah. I think in particular this touches some core parts, so I'm a bit concerned with adding this so late. I'd say let's leave it out for now; this seems relatively easy to introduce later on, too, if we think it becomes important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Testing Assigned automatically by the PR labeler C:x/consumer Assigned automatically by the PR labeler C:x/provider Assigned automatically by the PR labeler C:x/types Assigned automatically by the PR labeler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compute MinPowerToOptIn in EndBlock and cache, instead of computing on-the-fly
3 participants