refactor: check client status active when verify consensus state

[hoank101]

Closes: #1088

Description

---

PR author checklist:

• Added changelog entry, using unclog.
• Added tests.
• Linked to GitHub issue.
• Updated code comments and documentation (e.g., docs/).
• Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

• Reviewed Files changed in the GitHub PR explorer.
• Manually tested (in case integration/unit/mock tests are absent).

[rnbguy]

Thanks for your PR, @hoank101 ! But this issue is a bit nuanced, and my suggestion on the issue is was misleading.

is_active call on unstored client_id will return Frozen or Expired. Expired case happens because there is no consensus state present for that client_id - which is assumed to be pruned.

That's why you needed to insert a consensus state before executing MsgCreateClient. But that's not possible on live chain - and, this logic will always fail.

We need to check for the Expired status for the proved ConsensusState locally. To execute this nicely will require some careful changes in the traits.

[hoank101]

Thanks for your PR, @hoank101 ! But this issue is a bit nuanced, and my suggestion on the issue is was misleading.

is_active call on unstored client_id will return Frozen or Expired. Expired case happens because there is no consensus state present for that client_id - which is assumed to be pruned.

That's why you needed to insert a consensus state before executing MsgCreateClient. But that's not possible on live chain - and, this logic will always fail.

We need to check for the Expired status for the proved ConsensusState locally. To execute this nicely will require some careful changes in the traits.

thank you for feedback, i will update logic

[rnbguy]

Note how it's being handled in ibc-go here. The status is checked after the consensus state is stored.

But in ibc-rs, we separate validation and execution. If we followed ibc-go, we could have checked status.is_active() in execute() after the following.

ibc-rs/ibc-core/ics02-client/src/handler/create_client.rs

Lines 67 to 71 in 3b260e2

	client_state.initialise(
	ctx.get_client_execution_context(),
	&client_id,
	consensus_state,
	)?;

But this breaks the convention of our design.