-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove AllowUpdateAfterMisbehaviour/AllowUpdateAfterExpiry from 07-te… #5855
remove AllowUpdateAfterMisbehaviour/AllowUpdateAfterExpiry from 07-te… #5855
Conversation
…ndermint client state
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5855 +/- ##
=========================================
Coverage 81.59% 81.59%
=========================================
Files 199 198 -1
Lines 15167 12099 -3068
=========================================
- Hits 12375 9872 -2503
+ Misses 2326 1765 -561
+ Partials 466 462 -4
|
WalkthroughWalkthroughThe changes involve the removal of deprecated fields Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files ignored due to path filters (1)
modules/light-clients/07-tendermint/tendermint.pb.go
is excluded by!**/*.pb.go
,!**/*.pb.go
Files selected for processing (3)
- modules/core/02-client/proposal_handler_test.go (1 hunks)
- modules/light-clients/07-tendermint/proposal_handle.go (1 hunks)
- proto/ibc/lightclients/tendermint/v1/tendermint.proto (1 hunks)
Files skipped from review due to trivial changes (2)
- modules/light-clients/07-tendermint/proposal_handle.go
- proto/ibc/lightclients/tendermint/v1/tendermint.proto
Additional Context Used
Path-based Instructions (1)
modules/core/02-client/proposal_handler_test.go (2)
Pattern
**/*.go
: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
Pattern
**/*_test.go
: "Assess the unit test code assessing sufficient code coverage for the changes associated in the pull request"
Additional comments not posted (3)
modules/core/02-client/proposal_handler_test.go (3)
Line range hint
1-1
: The test suite structure and setup are well-organized and adhere to best practices.
Line range hint
1-1
: The removal of deprecated fields is correctly implemented and does not affect the test logic.
Line range hint
1-1
: The test cases are comprehensive and correctly test the client update proposal functionality.
Thanks @expertdicer for your contribution! We decided to wait on these changes for now |
…ndermint client state
Description
closes: #5750
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
).godoc
comments.Files changed
in the Github PR explorer.Codecov Report
in the comment section below once CI passes.Summary by CodeRabbit
Refactor
AllowUpdateAfterMisbehaviour
andAllowUpdateAfterExpiry
flags from the client state configuration.Chores