Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: include ics4Wrapper in hostkeeper.NewKeeper ics27 integration docs #2351

Merged
merged 3 commits into from Sep 26, 2022
Merged

docs: include ics4Wrapper in hostkeeper.NewKeeper ics27 integration docs #2351

merged 3 commits into from Sep 26, 2022

Conversation

damiannolan
Copy link
Member

Description

closes: #XXXX

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@damiannolan damiannolan merged commit d527aa3 into main Sep 26, 2022
@damiannolan damiannolan deleted the damian/update-ica-docs branch September 26, 2022 08:07
@mergify mergify bot mentioned this pull request Sep 26, 2022
Merged
mergify bot pushed a commit that referenced this pull request Sep 26, 2022
@damiannolan @mergify
docs: include ics4Wrapper in hostkeeper.NewKeeper ics27 integration…
e18a5f3 
… docs (#2351)

* updating ica integration docs

* Update docs/apps/interchain-accounts/integration.md

Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
(cherry picked from commit d527aa3)
mergify bot pushed a commit that referenced this pull request Sep 26, 2022
@damiannolan @mergify
docs: include ics4Wrapper in hostkeeper.NewKeeper ics27 integration…
b4e9dd6 
… docs (#2351)

* updating ica integration docs

* Update docs/apps/interchain-accounts/integration.md

Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
(cherry picked from commit d527aa3)
@mergify mergify bot mentioned this pull request Sep 26, 2022
Merged
damiannolan added a commit that referenced this pull request Sep 26, 2022
@mergify @damiannolan
docs: include ics4Wrapper in hostkeeper.NewKeeper ics27 integration…
259522d 
… docs (#2351) (#2380)

* updating ica integration docs

* Update docs/apps/interchain-accounts/integration.md

Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
(cherry picked from commit d527aa3)

Co-authored-by: Damian Nolan <damiannolan@gmail.com>
damiannolan added a commit that referenced this pull request Sep 26, 2022
@mergify @damiannolan
docs: include ics4Wrapper in hostkeeper.NewKeeper ics27 integration…
f4d010e 
… docs (#2351) (#2381)

* updating ica integration docs

* Update docs/apps/interchain-accounts/integration.md

Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
(cherry picked from commit d527aa3)

Co-authored-by: Damian Nolan <damiannolan@gmail.com>
@chatton chatton mentioned this pull request Nov 7, 2022
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crodriguezvega crodriguezvega crodriguezvega approved these changes

@chatton chatton chatton approved these changes

@colin-axner colin-axner Awaiting requested review from colin-axner colin-axner is a code owner

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal AdityaSripal is a code owner

@seantking seantking Awaiting requested review from seantking

@charleenfei charleenfei Awaiting requested review from charleenfei charleenfei is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@damiannolan @crodriguezvega @chatton