feat: add params for ics27 simulation #2160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…colin/1352-simparams
colin-axner
requested review from
seantking,
AdityaSripal and
damiannolan
as code owners
colin-axner
commented
Sep 6, 2022
Codecov Report
@@ Coverage Diff @@
## main #2160 +/- ##
==========================================
+ Coverage 79.48% 79.49% +0.01%
==========================================
Files 173 174 +1
Lines 12011 12028 +17
==========================================
+ Hits 9547 9562 +15
- Misses 2042 2044 +2
Partials 422 422
|
AdityaSripal
approved these changes
Sep 7, 2022
mergify bot
pushed a commit
that referenced
this pull request
Sep 7, 2022
* add param changes for ics27 simulation * account for unadded submodules * fix tests * Update modules/apps/27-interchain-accounts/module.go * add app simulation declaration (cherry picked from commit cd913b8) # Conflicts: # modules/apps/27-interchain-accounts/module.go
mergify bot
pushed a commit
that referenced
this pull request
Sep 7, 2022
* add param changes for ics27 simulation * account for unadded submodules * fix tests * Update modules/apps/27-interchain-accounts/module.go * add app simulation declaration (cherry picked from commit cd913b8) # Conflicts: # modules/apps/27-interchain-accounts/module.go
colin-axner
added a commit
that referenced
this pull request
Sep 8, 2022
* add param changes for ics27 simulation * account for unadded submodules * fix tests * Update modules/apps/27-interchain-accounts/module.go * add app simulation declaration (cherry picked from commit cd913b8) # Conflicts: # modules/apps/27-interchain-accounts/module.go Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
colin-axner
added a commit
that referenced
this pull request
Sep 8, 2022
* feat: add params for ics27 simulation (#2160) * add param changes for ics27 simulation * account for unadded submodules * fix tests * Update modules/apps/27-interchain-accounts/module.go * add app simulation declaration (cherry picked from commit cd913b8) # Conflicts: # modules/apps/27-interchain-accounts/module.go * fix conflicts Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #1352
closes: #2151
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes