Added interface to accept any type of ADR 031 message router. #2058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s added to the controller and host keepers.
Taztingo
requested review from
seantking,
colin-axner,
AdityaSripal and
damiannolan
as code owners
crodriguezvega
requested changes
Aug 19, 2022
There was a problem hiding this comment.
Thank you for opening the issue and fixing it, @Taztingo! :)
Could you please also add a changelog entry in the API breaking section?
modules/apps/27-interchain-accounts/controller/keeper/keeper.go
Outdated
Show resolved
Hide resolved
crodriguezvega
approved these changes
Aug 22, 2022
colin-axner
approved these changes
Aug 22, 2022
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
chatton
approved these changes
Aug 23, 2022
seantking
approved these changes
Aug 23, 2022
9 tasks
Taztingo
requested review from
damiannolan,
crodriguezvega and
seantking
and removed request for
damiannolan and
crodriguezvega
Taztingo
requested review from
colin-axner,
damiannolan,
crodriguezvega and
chatton
and removed request for
seantking,
colin-axner,
damiannolan and
crodriguezvega
mergify bot
pushed a commit
that referenced
this pull request
Aug 23, 2022
## Description Updated the controller and host keeper to take in an interface for the router. This allows systems that implement ADR 031, but do not use the default baseapp.router to use ICA. closes: #2044 --- Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why. - [ ] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work. - [ ] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules/structure.md). - [ ] Wrote unit and integration [tests](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#testing) - [ ] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`) - [ ] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code). - [ ] Added a relevant changelog entry to the `Unreleased` section in `CHANGELOG.md` - [ ] Re-reviewed `Files changed` in the Github PR explorer - [ ] Review `Codecov Report` in the comment section below once CI passes (cherry picked from commit 397b88c) # Conflicts: # CHANGELOG.md # modules/apps/27-interchain-accounts/controller/keeper/keeper.go # modules/apps/27-interchain-accounts/host/keeper/keeper.go
mergify bot
pushed a commit
that referenced
this pull request
Aug 23, 2022
## Description Updated the controller and host keeper to take in an interface for the router. This allows systems that implement ADR 031, but do not use the default baseapp.router to use ICA. closes: #2044 --- Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why. - [ ] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work. - [ ] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules/structure.md). - [ ] Wrote unit and integration [tests](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#testing) - [ ] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`) - [ ] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code). - [ ] Added a relevant changelog entry to the `Unreleased` section in `CHANGELOG.md` - [ ] Re-reviewed `Files changed` in the Github PR explorer - [ ] Review `Codecov Report` in the comment section below once CI passes (cherry picked from commit 397b88c) # Conflicts: # CHANGELOG.md # modules/apps/27-interchain-accounts/controller/keeper/keeper.go # modules/apps/27-interchain-accounts/host/keeper/keeper.go
damiannolan
added a commit
that referenced
this pull request
Aug 24, 2022
#2058) (#2088) * Added interface to accept any type of ADR 031 message router. (#2058) ## Description Updated the controller and host keeper to take in an interface for the router. This allows systems that implement ADR 031, but do not use the default baseapp.router to use ICA. closes: #2044 --- Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why. - [ ] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work. - [ ] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules/structure.md). - [ ] Wrote unit and integration [tests](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#testing) - [ ] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`) - [ ] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code). - [ ] Added a relevant changelog entry to the `Unreleased` section in `CHANGELOG.md` - [ ] Re-reviewed `Files changed` in the Github PR explorer - [ ] Review `Codecov Report` in the comment section below once CI passes (cherry picked from commit 397b88c) # Conflicts: # CHANGELOG.md # modules/apps/27-interchain-accounts/controller/keeper/keeper.go # modules/apps/27-interchain-accounts/host/keeper/keeper.go * fix conflict * fix conflict * fix conflict * Update keeper.go * Update keeper.go Co-authored-by: Matt Witkowski <mwitkowski@provenance.io> Co-authored-by: Carlos Rodriguez <carlos@interchain.io> Co-authored-by: Damian Nolan <damiannolan@gmail.com>
damiannolan
added a commit
that referenced
this pull request
Aug 24, 2022
#2058) (#2087) * Added interface to accept any type of ADR 031 message router. (#2058) ## Description Updated the controller and host keeper to take in an interface for the router. This allows systems that implement ADR 031, but do not use the default baseapp.router to use ICA. closes: #2044 --- Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why. - [ ] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work. - [ ] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules/structure.md). - [ ] Wrote unit and integration [tests](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#testing) - [ ] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`) - [ ] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code). - [ ] Added a relevant changelog entry to the `Unreleased` section in `CHANGELOG.md` - [ ] Re-reviewed `Files changed` in the Github PR explorer - [ ] Review `Codecov Report` in the comment section below once CI passes (cherry picked from commit 397b88c) # Conflicts: # CHANGELOG.md # modules/apps/27-interchain-accounts/controller/keeper/keeper.go # modules/apps/27-interchain-accounts/host/keeper/keeper.go * fix conflict * fix conflict * Update keeper.go * Update keeper.go * Update keeper.go Co-authored-by: Matt Witkowski <mwitkowski@provenance.io> Co-authored-by: Carlos Rodriguez <carlos@interchain.io> Co-authored-by: Damian Nolan <damiannolan@gmail.com>
crodriguezvega
added a commit
that referenced
this pull request
Sep 7, 2022
crodriguezvega
added a commit
that referenced
this pull request
Sep 26, 2022
* wip: migration docs v4 to v5 * adding some code diffs * adding more code snippets and diffs * add link to docs * fix alignment * fix alignment * fix alignment * fix typo * code improvement * add links to sections in the document * add migration docs for #2058 * added link to PR that renamed the ante decorator * changes for #2083 * docs: updating migration docs with additional ics27 host parameter (#2309) * updating migration docs with additional ics27 host parameter * fix indentation Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> Co-authored-by: Damian Nolan <damiannolan@gmail.com>
mergify bot
pushed a commit
that referenced
this pull request
Sep 26, 2022
* wip: migration docs v4 to v5 * adding some code diffs * adding more code snippets and diffs * add link to docs * fix alignment * fix alignment * fix alignment * fix typo * code improvement * add links to sections in the document * add migration docs for #2058 * added link to PR that renamed the ante decorator * changes for #2083 * docs: updating migration docs with additional ics27 host parameter (#2309) * updating migration docs with additional ics27 host parameter * fix indentation Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> Co-authored-by: Damian Nolan <damiannolan@gmail.com> (cherry picked from commit a278287)
mergify bot
pushed a commit
that referenced
this pull request
Sep 26, 2022
* wip: migration docs v4 to v5 * adding some code diffs * adding more code snippets and diffs * add link to docs * fix alignment * fix alignment * fix alignment * fix typo * code improvement * add links to sections in the document * add migration docs for #2058 * added link to PR that renamed the ante decorator * changes for #2083 * docs: updating migration docs with additional ics27 host parameter (#2309) * updating migration docs with additional ics27 host parameter * fix indentation Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> Co-authored-by: Damian Nolan <damiannolan@gmail.com> (cherry picked from commit a278287)
crodriguezvega
added a commit
that referenced
this pull request
Sep 26, 2022
* wip: migration docs v4 to v5 * adding some code diffs * adding more code snippets and diffs * add link to docs * fix alignment * fix alignment * fix alignment * fix typo * code improvement * add links to sections in the document * add migration docs for #2058 * added link to PR that renamed the ante decorator * changes for #2083 * docs: updating migration docs with additional ics27 host parameter (#2309) * updating migration docs with additional ics27 host parameter * fix indentation Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> Co-authored-by: Damian Nolan <damiannolan@gmail.com> (cherry picked from commit a278287) Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
damiannolan
pushed a commit
that referenced
this pull request
Sep 26, 2022
* wip: migration docs v4 to v5 * adding some code diffs * adding more code snippets and diffs * add link to docs * fix alignment * fix alignment * fix alignment * fix typo * code improvement * add links to sections in the document * add migration docs for #2058 * added link to PR that renamed the ante decorator * changes for #2083 * docs: updating migration docs with additional ics27 host parameter (#2309) * updating migration docs with additional ics27 host parameter * fix indentation Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> Co-authored-by: Damian Nolan <damiannolan@gmail.com> (cherry picked from commit a278287) Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated the controller and host keeper to take in an interface for the router. This allows systems that implement ADR 031, but do not use the default baseapp.router to use ICA.
closes: #2044
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes