docs: cleanup wasm_hook.go #165
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated few comments and simplified the code.
github-actions
bot
added
the
ibc-hooks
robert-zaremba
commented
Feb 27, 2024
| @@ -181,7 +177,6 @@ func ValidateAndParseMemo(memo string, receiver string) (isWasmRouted bool, cont | |||
| fmt.Errorf(types.ErrBadMetadataFormatMsg, memo, "wasm metadata is not a valid JSON map object") | |||
| } | |||
|
|
|||
| // Get the contract | |||
There was a problem hiding this comment.
this comment doesn't bring anything. The implementation and the error message is clear and short, so it's better to read the code than the comment.
Rule 1: Comments should not duplicate the code
There was a problem hiding this comment.
same comment applies to few changes below
|
The team just updated main to SDK v50, if you want to rebase on that I am happy to approve myself to get in the updated docs If not I will update this PR when I can and get in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated few comments and simplified the code.