Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output: fix sarif formatting #39

Merged
merged 1 commit into from Sep 15, 2022
Merged

output: fix sarif formatting #39

merged 1 commit into from Sep 15, 2022

Conversation

kirbyquerby
Copy link
Collaborator

This change is based on securego/gosec#565 .

Fixes include:

  • add a version field to the driver
  • report start and end line of issues
  • report correct sarif level based on the issue's reported severity rather than always warning
  • avoid duplicate entries in rules

Updates #38

This change is based on securego/gosec#565 .

Fixes include:
* add a version field to the driver
* report start and end line of issues
* report correct sarif level based on the issue's reported severity rather than always warning
* avoid duplicate entries in rules

Updates cosmos#38
Copy link
Collaborator

@odeke-em odeke-em left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @kirbyquerby!

output/formatter.go Show resolved Hide resolved
@kirbyquerby kirbyquerby merged commit c75406a into cosmos:master Sep 15, 2022
@kirbyquerby kirbyquerby deleted the sarif branch September 15, 2022 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants